Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enum variants to be used as label values #49

Closed
wants to merge 12 commits into from
Closed

Allow enum variants to be used as label values #49

wants to merge 12 commits into from

Conversation

sagacity
Copy link

Closes #17.

@sagacity sagacity marked this pull request as draft March 10, 2023 13:45
@sagacity sagacity force-pushed the derive-enum-labels branch from c4ee80b to 1fd408b Compare March 15, 2023 13:38
@sagacity sagacity marked this pull request as ready for review March 15, 2023 13:38
emschwartz
emschwartz suggested changes Mar 16, 2023
View reviewed changes
autometrics-macros/src/lib.rs Outdated Show resolved Hide resolved
autometrics/src/lib.rs Outdated Show resolved Hide resolved
autometrics-macros/src/lib.rs Show resolved Hide resolved
autometrics-macros/src/lib.rs Outdated Show resolved Hide resolved
autometrics-macros/src/lib.rs Outdated Show resolved Hide resolved
autometrics-macros/src/lib.rs Show resolved Hide resolved
@sagacity
Copy link
Author

Hmm, in the integration test the correct traits aren't being called, so I'll have to shuffle things around some more.

@emschwartz emschwartz closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emschwartz emschwartz emschwartz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label derive macro
2 participants
@sagacity @emschwartz