-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename metrics to be in line with OTel + Prometheus conventions #21
Comments
The error rate SLO expression still expects autometrics-shared/autometrics.rules.yml Line 11 in 79d53e9
An extra change is needed in the generated rules file to make the alerts work once libraries make the change to support Also, the histogram queries for the latency SLO haven't been renamed either autometrics-shared/autometrics.rules.yml Line 825 in 79d53e9
So |
maybe we should fix the queries in https://github.com/autometrics-dev/autometrics-shared/pull/60/files and merge it? wasn't sure if that PR was unmerged for a reason |
As discussed here, OpenTelemetry is changing its semantic conventions to remove the
.count
suffix. Also, as discussed here, the histogram should include the units in the name for Prometheus.We should update all of the libraries such that:
function.calls.count
tofunction.calls
function_calls_total
and the histogram is renamed tofunction_calls_duration_seconds
function_calls_total
andfunction_calls_duration_seconds
name. We can give people time to update things by making the alerting rules and dashboards support the new and old names using regular expressions.TODO:
function.calls.count
tofunction.calls
autometrics-go#54The text was updated successfully, but these errors were encountered: