Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner)!: remove velocity_factor completely #9943

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 16, 2025

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 29.13%. Comparing base (cde1c78) to head (8e0341d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ior_velocity_no_drivable_lane_module/src/scene.cpp 0.00% 9 Missing ⚠️
...elocity_virtual_traffic_light_module/src/scene.cpp 0.00% 6 Missing ⚠️
...e_behavior_velocity_stop_line_module/src/scene.cpp 0.00% 4 Missing ⚠️
...avior_velocity_detection_area_module/src/scene.cpp 0.00% 3 Missing ⚠️
...topping_area_module/src/scene_no_stopping_area.cpp 0.00% 3 Missing ⚠️
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9943      +/-   ##
==========================================
- Coverage   29.14%   29.13%   -0.01%     
==========================================
  Files        1425     1426       +1     
  Lines      107819   107825       +6     
  Branches    42246    42241       -5     
==========================================
- Hits        31422    31415       -7     
- Misses      73352    73365      +13     
  Partials     3045     3045              
Flag Coverage Δ *Carryforward flag
differential 27.84% <0.00%> (?)
total 29.14% <ø> (+<0.01%) ⬆️ Carriedforward from cde1c78

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r
Copy link
Member

This PR is remaining items from #9927.
Since the modification is made across many packages, I will merge it as admin.

@mitsudome-r mitsudome-r merged commit 67ab350 into autowarefoundation:main Jan 16, 2025
45 of 46 checks passed
@mitsudome-r mitsudome-r deleted the chore/bvp-remove-velocity-factor-include branch January 16, 2025 15:05
TetsuKawa pushed a commit to TetsuKawa/autoware.universe that referenced this pull request Jan 20, 2025
…utowarefoundation#9943)

* feat(behavior_velocity_planner)!: remove velocity_factor completely

Signed-off-by: Mamoru Sobue <[email protected]>

* minimize diff

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: TetsuKawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants