Refactor plugin impls to be generic; implement ndim convolution (no grad for now); fix conv tests. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/autumnai/collenchyma-nn/blob/master/CONTRIBUTING.md#git-commit-guidelines This message was auto-generated by https://gitcop.com |
Author
|
It's late here, so I'll fix the gitcop issues tomorrow. |
DiamondLovesYou
force-pushed
the
generic-cuda
branch
from
e946083 to
fed4392
Compare
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/autumnai/collenchyma-nn/blob/master/CONTRIBUTING.md#git-commit-guidelines This message was auto-generated by https://gitcop.com |
…da backend This allows the tests/downstream crates to be generic. For Cuda, this doesn't expand the types allowed, so only `f32` and `f64` are allowed (just as before).
…the native backend This algo needs to allocate a few index vectors, however it requires no additional space.
DiamondLovesYou
force-pushed
the
generic-cuda
branch
from
fed4392 to
d5ab0d0
Compare
Author
|
I've fixed the gitcop issues. |
This was referenced Apr 30, 2016
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This algo performs a fairly simple, probably slow, inplace convolution over n-dimensional input. While cleaning up the tests, I ran into issues where trait impls aren't implemented on generic types, which is desired to combat code duplication, so I've fixed that. While Cuda is limited to
f32&&f64, this algo can run over any type that implements (mainly)AddandMul.Note that this PR depends on autumnai/rust-cudnn#23, so accept that one first.