DONOTMERGE: coreth graft via subtree merge

.github/CODEOWNERS

@@ -20,6 +20,8 @@
 /Taskfile.yml @joshua-kim @maru-ava
 /flake.lock @joshua-kim @maru-ava
 /flake.nix @joshua-kim @maru-ava
+/graft/coreth @ava-labs/platform-evm
+/graft/coreth/triedb/firewood/ @alarso16 @ava-labs/platform-evm
 /network/p2p/ @joshua-kim
 /network/p2p/*.md @joshua-kim @meaghanfitzgerald
 /nix/* @joshua-kim @maru-ava

.github/workflows/ci.yml

@@ -32,8 +32,19 @@ jobs:
       - name: test-unit
         shell: bash
         run: ./scripts/run_task.sh test-unit
-        env:
-          TIMEOUT: ${{ env.TIMEOUT }}
+  Unit-coreth:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [macos-14, ubuntu-22.04, ubuntu-24.04, custom-arm64-jammy, custom-arm64-noble]
+        run_number: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30]
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/setup-go-for-project
+      - name: test-unit
+        shell: bash
+        run: ./scripts/run_task.sh test-unit-coreth
   Fuzz:
     runs-on: ubuntu-latest
     steps:
@@ -113,6 +124,22 @@ jobs:
           loki_push_url: ${{ secrets.LOKI_PUSH_URL || '' }}
           loki_username: ${{ secrets.LOKI_USERNAME || '' }}
           loki_password: ${{ secrets.LOKI_PASSWORD || '' }}
+  e2e_warp:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/run-monitored-tmpnet-cmd
+        with:
+          run: ./scripts/run_task.sh test-e2e-warp-ci
+          artifact_prefix: e2e-warp
+          prometheus_url: ${{ secrets.PROMETHEUS_URL || '' }}
+          prometheus_push_url: ${{ secrets.PROMETHEUS_PUSH_URL || '' }}
+          prometheus_username: ${{ secrets.PROMETHEUS_USERNAME || '' }}
+          prometheus_password: ${{ secrets.PROMETHEUS_PASSWORD || '' }}
+          loki_url: ${{ secrets.LOKI_URL || '' }}
+          loki_push_url: ${{ secrets.LOKI_PUSH_URL || '' }}
+          loki_username: ${{ secrets.LOKI_USERNAME || '' }}
+          loki_password: ${{ secrets.LOKI_PASSWORD || '' }}
   Upgrade:
     runs-on: ubuntu-latest
     steps:
@@ -171,6 +198,14 @@ jobs:
       - uses: ./.github/actions/setup-go-for-project
       - shell: bash
         run: ./scripts/run_task.sh check-generate-canoto
+  check_codec:
+    name: Up-to-date codec
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/setup-go-for-project
+      - shell: bash
+        run: ./scripts/run_task.sh check-generate-codec
   check_contract_bindings:
     name: Up-to-date contract bindings
     runs-on: ubuntu-latest
@@ -179,6 +214,14 @@ jobs:
       - uses: ./.github/actions/install-nix
       - shell: nix develop --command bash -x {0}
         run: task check-generate-load-contract-bindings
+  check_rlp:
+    name: Up-to-date rlp
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/setup-go-for-project
+      - shell: bash
+        run: ./scripts/run_task.sh check-generate-rlp
   go_mod_tidy:
     name: Up-to-date go.mod and go.sum
     runs-on: ubuntu-latest

.golangci.yml

@@ -29,6 +29,24 @@ issues:
   # Maximum count of issues with the same text.
   max-same-issues: 0
 
+formatters:
+  enable:
+    - gci
+    - gofmt
+    - gofumpt
+  settings:
+    gci:
+      sections:
+        - standard
+        - default
+        - blank
+        - prefix(github.com/ava-labs/avalanchego)
+        - alias
+        - dot
+      custom-order: true
+  exclusions:
+    generated: lax
+
 linters:
   default: none
   enable:
@@ -236,24 +254,7 @@ linters:
       # 2. Exclude any file prefixed with test_ in any directory.
       # 3. Exclude any directory suffixed with test.
       # 4. Exclude any file suffixed with _test.go.
-      - path: "(^tests/)|(^(.*/)*test_[^/]*\\.go$)|(.*test/.*)|(.*_test\\.go$)"
+      - path: "/[^/]*tests?/|(^|.*/)(test_[^/]*\\.go$)|(_test\\.go$)"
         linters:
           - gosec
           - prealloc
-formatters:
-  enable:
-    - gci
-    - gofmt
-    - gofumpt
-  settings:
-    gci:
-      sections:
-        - standard
-        - default
-        - blank
-        - prefix(github.com/ava-labs/avalanchego)
-        - alias
-        - dot
-      custom-order: true
-  exclusions:
-    generated: lax

.legacy-golangci.yml

@@ -0,0 +1,77 @@
+version: "2"
+run:
+  tests: true
+
+linters:
+  default: none
+  enable:
+    - bidichk
+    - copyloopvar
+    - durationcheck
+    - gocheckcompilerdirectives
+    - govet
+    - ineffassign
+    - mirror
+    - misspell
+    - reassign
+    # - revive # only certain checks enabled
+    - staticcheck 
+    - unconvert
+    - unused
+    - whitespace
+  settings:
+    goconst:
+      min-len: 3 # minimum length of string constant
+      min-occurrences: 6 # minimum number of occurrences
+    staticcheck:
+      checks:
+        - all
+
+        # There's a lot of legacy code that triggers these warnings after upgrading golangci-lint.
+        # These checks are removed.
+        - -QF1001  # Apply De Morgan’s law
+        - -QF1002  # Convert an untagged switch comparing the same variable into a “tagged” switch
+        - -QF1003  # Convert if / else-if chains comparing the same variable into a tagged switch
+        - -QF1006  # Lift if + break into loop condition
+        - -QF1008  # Omit embedded fields from selector expression
+        - -QF1010  # Convert slice of bytes to string when printing it
+        - -SA1019  # Use of deprecated identifiers: triggers when you import or use something marked deprecated. 
+        - -SA4009  # A function argument is overwritten before its first use. 
+        - -SA9003  # Empty body in an if or else branch.
+        - -ST1003  # Poorly chosen identifier.
+        - -ST1008  # A function’s error value should be its last return value.
+        - -ST1016  # Use consistent method receiver names (e.g. avoid mixing `s *S`, `s S`, `t *T` in same type).
+
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - unused
+        # Exclude unused geth symbols from ethclient/ethclient.go to simplify upgrading Geth to a newer version.
+        path: ethclient\/ethclient\.go
+        text: (type `rpcProgress`|func `\(\*rpcProgress\)\.toSyncProgress`) is unused
+      - linters:
+          - goconst
+        path: (.+)_test\.go
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+
+formatters:
+  enable:
+    - goimports
+  settings:
+    gofmt:
+      simplify: true
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Taskfile.yml

@@ -61,6 +61,12 @@ tasks:
       - task: generate-canoto
       - task: check-clean-branch
 
+  check-generate-codec:
+    desc: Checks that generated codec files are up-to-date (requires a clean git working tree)
+    cmds:
+      - task: generate-codec
+      - task: check-clean-branch
+
   check-generate-load-contract-bindings:
     desc: Checks that generated load contract bindings are up-to-date (requires a clean git working tree)
     cmds:
@@ -79,6 +85,12 @@ tasks:
       - task: generate-protobuf
       - task: check-clean-branch
 
+  check-generate-rlp:
+    desc: Checks that generated rlp files are up-to-date (requires a clean git working tree)
+    cmds:
+      - task: generate-rlp
+      - task: check-clean-branch
+
   check-go-mod-tidy:
     desc: Checks that go.mod and go.sum are up-to-date (requires a clean git working tree)
     cmds:
@@ -118,11 +130,17 @@ tasks:
     desc: Generates testing mocks
     cmds:
       - cmd: grep -lr -E '^// Code generated by MockGen\. DO NOT EDIT\.$' . | xargs -r rm
-      - cmd: go generate -run "go.uber.org/mock/mockgen" ./...
+      - cmd: go generate -run "mockgen" ./...
 
   generate-canoto:
     desc: Generates canoto
-    cmd: go generate -run "github.com/StephenButtolph/canoto/canoto" ./...
+    cmd: go generate -run "canoto" ./...
+
+  generate-codec:
+    desc: Generates fjl/gencodec files
+    cmds:
+      - cmd: grep -lr -E '^// Code generated by github\\.com\\/fjl\\/gencodec\\. DO NOT EDIT\\.$' . | xargs -r rm
+      - cmd: go generate -run gencodec ./...
 
   generate-load-contract-bindings:
     desc: Generates load contract bindings
@@ -134,6 +152,12 @@ tasks:
     desc: Generates protobuf
     cmd: ./scripts/protobuf_codegen.sh
 
+  generate-rlp:
+    desc: Generates rlp files
+    cmds:
+      - cmd: grep -lr -E '^// Code generated by rlpgen\\. DO NOT EDIT\\.$' . | xargs -r rm
+      - cmd: go generate -run "github.com/ava-labs/libevm/rlp/rlpgen" ./...
+
   ginkgo-build:
     desc: Runs ginkgo against the current working directory
     cmd: ./bin/ginkgo build {{.USER_WORKING_DIR}}
@@ -172,7 +196,7 @@ tasks:
 
   lint-fix:
     desc: Runs automated fixing for failing static analysis of golang code
-    cmd: ./scripts/run_tool.sh golangci-lint run --config .golangci.yml --fix
+    cmd: ./scripts/lint_fix.sh
 
   lint-action:
     desc: Runs actionlint to check sanity of github action configuration
@@ -326,6 +350,23 @@ tasks:
     cmds:
       - cmd: bash -x ./scripts/tests.e2e.kube.sh --ginkgo.focus-file=xsvm.go {{.CLI_ARGS}}
 
+  test-e2e-warp:
+    desc: Run end-to-end warp tests using Ginkgo test framework
+    env:
+      E2E_TARGET: ./graft/coreth/tests/warp
+    cmds:
+      - task: build
+      - cmd: bash -x ./scripts/tests.e2e.sh {{.CLI_ARGS}}
+
+  test-e2e-warp-ci:
+    desc: Run E2E warp tests with CI setup (race detection enabled)
+    env:
+      E2E_TARGET: ./graft/coreth/tests/warp
+      E2E_SERIAL: 1
+    cmds:
+      - task: build-race
+      - cmd: bash -x ./scripts/tests.e2e.sh {{.CLI_ARGS}}
+
   # To use a different fuzz time, run `task test-fuzz FUZZTIME=[value in seconds]`.
   # A value of `-1` will run until it encounters a failing output.
 
@@ -378,9 +419,12 @@ tasks:
 
   test-unit:
     desc: Runs unit tests
-    # Invoking with bash ensures compatibility with CI execution on Windows
     cmd: bash ./scripts/build_test.sh
 
+  test-unit-coreth:
+    desc: Runs unit tests for coreth
+    cmd: bash ./scripts/tests.unit.coreth.sh
+
   test-unit-fast:
     desc: Runs unit tests
     env:

chains/atomic/mocks_generate_test.go

@@ -3,4 +3,4 @@
 
 package atomic
 
-//go:generate go run go.uber.org/mock/mockgen -package=${GOPACKAGE}mock -destination=${GOPACKAGE}mock/shared_memory.go -mock_names=SharedMemory=SharedMemory . SharedMemory
+//go:generate go tool mockgen -package=${GOPACKAGE}mock -destination=${GOPACKAGE}mock/shared_memory.go -mock_names=SharedMemory=SharedMemory . SharedMemory

codec/mocks_generate_test.go

@@ -3,4 +3,4 @@
 
 package codec
 
-//go:generate go run go.uber.org/mock/mockgen -package=${GOPACKAGE}mock -destination=${GOPACKAGE}mock/manager.go -mock_names=Manager=Manager . Manager
+//go:generate go tool mockgen -package=${GOPACKAGE}mock -destination=${GOPACKAGE}mock/manager.go -mock_names=Manager=Manager . Manager

database/mocks_generate_test.go

@@ -3,5 +3,5 @@
 
 package database
 
-//go:generate go run go.uber.org/mock/mockgen -package=${GOPACKAGE}mock -destination=${GOPACKAGE}mock/batch.go -mock_names=Batch=Batch . Batch
-//go:generate go run go.uber.org/mock/mockgen -package=${GOPACKAGE}mock -destination=${GOPACKAGE}mock/iterator.go -mock_names=Iterator=Iterator . Iterator
+//go:generate go tool mockgen -package=${GOPACKAGE}mock -destination=${GOPACKAGE}mock/batch.go -mock_names=Batch=Batch . Batch
+//go:generate go tool mockgen -package=${GOPACKAGE}mock -destination=${GOPACKAGE}mock/iterator.go -mock_names=Iterator=Iterator . Iterator