Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Avalanchego signature aggregation #596

Open
cam-schultz opened this issue Dec 13, 2024 · 0 comments
Open

Incorporate Avalanchego signature aggregation #596

cam-schultz opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@cam-schultz
Copy link
Collaborator

Context and scope
ava-labs/avalanchego#3394 adds a signature aggregation utility to Avalanchego that, when integrated, would allow us to remove a significant amount of duplicate functionality. The new utility uses p2p.Client, which encapsulated much of the p2p request handling that we currently implement ourselves.

Discussion and alternatives
We can replace much of the logic in SignatureAggregator.CreateSignedMessage with a call to this utility. We'll have to refactor the retry logic somewhat, but the utility does support this by accepting a partial aggregate signature as an argument.

We should also be able to replace much of the external handler logic (or remove it altogether), since the utility manages response handling.

Open questions
The Avalanchego aggregator does not support our use case of reconstructing an aggregate signature from cached individual signatures in the event of a validator set change. To do so, we would need a mapping of BLS public key to signature for a particular Warp message ID.

@cam-schultz cam-schultz added the enhancement New feature or request label Dec 13, 2024
@iansuvak iansuvak self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants