-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Tool-tip on player icons (captions/full-screen) neither shows current state or action to be performed #2020
Comments
@Karthikeya212 Unrelated to this issue, that screenshot shows the captions button on the far right, but full screen should always be on the far right. Can you create a new issue if that is still happening for you on spruce? |
@cjcolvar This issue is not related to being or not in full screen mode. This ticket relates to the text of the tool tip. That text does not tell us if we are turning on or off captions; or if we are entering or exiting full screen. The action that the click will perform is not clear given the text. In the case of the captions, it is more important because the icon is the same for turning on or off, but in general the tip should be clear about the action being taken. |
Side note: the icon used to change colors depending upon the CC state. Does that no longer happen? |
@bkeese yeah the captions icon changes its color, but I have added this as to maintain consistency in the icon actions, i.e. if an icon click changes its state (binary) it would be better if we show in the tooltip - the state to change (or) the changed state depending on the wording of that verb. As we cannot show a similar type of mapping (color change) for full-screen. |
@mcwhitaker Captions should work on spruce now that #1952 has been fixed. |
@Karthikeya212 the full screen icon also changes (not in color, but the actual design). However, when using the captions, I had never noticed that the icon changed color and I have wondered at times when no captions were showing if the captions were on or off. I think that this suggested change would be an improvement, although the existence of these alternatives may move this particular ticket lower on the list of UX improvements. |
@cjcolvar the captions button is not on the far right for me anymore. I think that screenshot might have been from hemlock, but at this point I don't think we should worry about it if it is not happening on spruce. |
@cjcolvar @mcwhitaker I have reproduced this scenario of captions icon being on far right, this is occurring with multiple sections having captions file in an item. The icon is in the correct position only for the first section of an item and that too only for one time play before switching to next section. The icon goes to far right in the below scenarios. (i) The player auto-switched to next session. But once any of these scenarios happen the captions file is remaining to far right for all the sections including the first section until we refresh. Please use the below items to verify this scenario. |
@Karthikeya212 good catch! |
Observations
Screenshots
The text was updated successfully, but these errors were encountered: