Item lease for IP addresses is giving access to the items past the given end date

[Karthikeya212]

Descriptive summary

Server: mco-staging.dlib.indiana.edu
Testing: Regression
Browser: Chrome(56.0.2924.87 (64-bit))
Operating System: Windows10
Issue: Item lease added for an ip-address with some date range is giving access to those items even after the date range is expired. This functionality is working fine for lease access to Avalon User and Avalon Group.

Expected behavior

Actual behavior

Steps to reproduce the behavior

1. Open two windows with sodium system, and login with a Manager on one system and donot login in the second one.
2. Edit an item, and add lease for that systems ip-address with date ranges that are already expired (i.e past dates).
3. After adding the lease, publish the item.
4. Search for the item in second window (without login), as the lease has expired this item shouldn't be shown, but it shows.
5. The only way to restrict the access for the ip's is to remove the lease entry.

Related work

Link to related tickets or prior related work here.

[cjcolvar]

This also applies to external groups.

For some reason we are including the values from the lease into the solrized media object. The code that causes this problem is here:
https://github.com/avalonmediasystem/avalon/blob/develop/app/models/media_object.rb#L203-L204

[cjcolvar]

Looks like it was added here to have the values show up in the facet:
780edfd

This maybe has always been broken, I'll have to think about how to fix it.

[joncameron]

This needs to be retested. Still valid?

[cjcolvar]

I think this is still valid and I hit it during regression testing. It is listed on our known issues page and I think it might be hard to solve.

[joncameron]

Boils down to an issue of how the solr query is written.