Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify ml input data type to one interface #138

Open
aatmunbaxi opened this issue Oct 9, 2023 · 3 comments
Open

Unify ml input data type to one interface #138

aatmunbaxi opened this issue Oct 9, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@aatmunbaxi
Copy link
Contributor

aatmunbaxi commented Oct 9, 2023

Many ml algorithms use a similar (or verbatim) same type of input. i.e. a matrix X that has samples along the rows with each column being a certain feature of the data, and column vector y that has labels indicating what class each sample belongs to in the case of classification, or output points in the case of regression.

To avoid rewriting the handling of this data for every ml module, maybe we can make a single interface (maybe MLInput?) that stores this information and is used as an input for the ml modules?

@aatmunbaxi
Copy link
Contributor Author

I'm working on a draft of such an interface. See here for an idea of what it looks like.

@avhz
Copy link
Owner

avhz commented Oct 11, 2023

I agree, makes sense to have one interface for all of them.

@avhz avhz added the enhancement New feature or request label Oct 11, 2023
@avhz
Copy link
Owner

avhz commented Oct 11, 2023

Just a heads up, I have unpacked the ml sub-directories, as it is not a very big module yet so the extra folders are not necessary imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants