Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making domain as boundary to access snitch_core functionality. #61

Open
arjun289 opened this issue May 5, 2018 · 0 comments
Open

Making domain as boundary to access snitch_core functionality. #61

arjun289 opened this issue May 5, 2018 · 0 comments

Comments

@arjun289
Copy link
Collaborator

arjun289 commented May 5, 2018

Context

At present we don't have any rule for limiting the access of domain, model and schema functions outside snitch_core.

The possible scenarios are

  1. Allowing model functions to be used outside snitch_core.

    • pros

      1. CRUD functions for a model don't need to be re-written in the domain module for accessing in another application so no code repetition.
    • cons

      1. For large projects IMO and as per the project I have experience with it's always better to have a single point of access to another application.
  2. Allowing all the access to snitch_core through domain modules.

    • pros
      1. Single point of accessibility so there is always a consistency maintained.
    • cons
      1. Code repetition in case of CRUD functions which are already there.

These are my views, I would like other people to put in their inputs and we can create some conventions and rules around that to be followed in snitch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant