Add support for Float #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q-uint
requested changes
Dec 20, 2022
src/JSON.mo
Outdated
|
|
||
| public func show(json : JSON) : Text = switch (json) { | ||
| case (#Number(v)) { Int.toText(v); }; | ||
| case (#Float(v)) { Float.format(#fix 2, v); }; |
Contributor
There was a problem hiding this comment.
We should not lose precision in the textual representation.
Author
There was a problem hiding this comment.
I updated the code so it returns the exact format.
Author
Author
|
Also, I tried to implement the number fraction exponent in this #3, but I think there will be some confusion because motoko only recognizes the format as a |
q-uint
requested changes
Dec 29, 2022
test/Show.mo
Outdated
Comment on lines
10
to
12
| assert (JSON.show(#Float(-3.14)) == "-3.1400000000000001"); | ||
| assert (JSON.show(#Float(1.234e-4)) == "0.00012339999999999999"); | ||
| assert (JSON.show(#Float(43e-02)) == "0.42999999999999999"); |
Contributor
There was a problem hiding this comment.
Motoko does not seem to work well with precision.
q-uint
reviewed
Jan 3, 2023
Contributor
q-uint
left a comment
q-uint
left a comment
There was a problem hiding this comment.
Can you mention that a Float only has two decimals somewhere in the README?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
#Floatto theJSONvariantFloatshow()andparse()