Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support chinese #65

Open
xiaoDC opened this issue Jul 8, 2019 · 7 comments
Open

support chinese #65

xiaoDC opened this issue Jul 8, 2019 · 7 comments
Labels
bug Something isn't working

Comments

@xiaoDC
Copy link

xiaoDC commented Jul 8, 2019

can you support chinese comment? tky

@aviaviavi
Copy link
Owner

Thanks for opening @xiaoDC. Do you mean supporting chinese flags for TODO, FIXME, etc? If so, you should be able to use the flags setting in your toodles.yaml config to set whatever flags you want. If this isn't what you meant, can you describe what you're wanting a little more? Maybe an example of what you'd like to be able to do would be helpful.

@xiaoDC
Copy link
Author

xiaoDC commented Jul 9, 2019

I mean if i use // TODO(fri3nds|p1) 添加接口,toodles happen with error. So i wish you can support 添加接口

@aviaviavi
Copy link
Owner

Ok I see. I actually would have expected this to work, so looks like a bug. I'll have a chance to look into this soon.

@aviaviavi aviaviavi added the bug Something isn't working label Jul 9, 2019
@aviaviavi
Copy link
Owner

@xiaoDC can you paste in the error you're getting, and any OS details? I just tried doing this on mac and it actually seems to work fine for me. can't seem to reproduce.

Screen Shot 2019-07-11 at 3 26 34 PM

@xiaoDC
Copy link
Author

xiaoDC commented Jul 17, 2019

I use docker run -it -v $(pwd):/repo -p 9001:9001 aviaviavi/toodles。And in my project, there are some comments which like// 新建cmd,the error is

Running toodles for path: /repo
/repo/pkg/command/cmd.go: hGetContents: invalid argument (invalid byte sequence)

@aviaviavi
Copy link
Owner

I see, must be some other unicode issue. I'll look into it, thanks for getting back to me

@Saeger
Copy link

Saeger commented Aug 4, 2019

Something isn’t operating as UTF-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants