Worker architecture capability added #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Smolianin <[email protected]>
beefon
reviewed
Aug 30, 2022
| enum Arch: String { | ||
| case m1 = "Apple M1" | ||
| case x86 = "Intel" | ||
| case unknown //for m2 .etc |
There was a problem hiding this comment.
Did you want to expose CPU arch (x86_64, arm64), or CPU type, or CPU manufacturer? It seems currently these all are messed up a bit.
I assume it is more beneficial to have arch rather than manufacturer or kind (i.e. Core i5 or i7 or M1 or M2 Pro vs x86_64 and arm64). Could you please update your PR to expose architecture only?
beefon
reviewed
Aug 30, 2022
| } | ||
|
|
||
| extension CommandExecutor { | ||
| public func executeCommandWithOutput(env: Dictionary<String,String>, arguments: [String]) throws -> String { |
There was a problem hiding this comment.
It is better to use ProcessControllerProvider to execute subcommands instead of adding another level of abstraction.
https://github.com/avito-tech/CommandLineToolkit/blob/master/Sources/ProcessController/ProcessControllerProvider.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new worker architecture capability. Only two architectures added "m1" and "x86". If something is wrong "unknown" architecture is set.