Default shared configuration has incorrect assumptions

[pevogam]

The setting in

avocado-vt/virttest/shared/cfg/guest-hw.cfg

Line 88 in 80ca89f

image_boot~=yes

has preceding comment

        # Add -drive ...boot=yes unless qemu-kvm is 0.12.1.2 or newer
        # then kvm_vm will ignore this option.

but on most recent Qemu 8.2 it is not ignored and rather has a dramatic effect on our VT tests where the image will be strictly booted in cases of UEFI reinstallation and USB installation tests that previously relied on alternative boot order configuration using Avocado VT. Is this default really intended to be set? If not I would recommend

-         image_boot~=yes
+         # image_boot~=yes

which used to be the case long ago. Is there any other purpose behind this parameter and its meaning different then the above-mentioned comment?

@luckyh @YongxueHong Do you happen to know more about this choice?

[luckyh]

@pevogam sorry, I cannot recall on that since it was introduced too long ago (more than 10 years)... anyway, I'd like to prefer to drop the setting as well due to

• we don't apply such a setting to other kind of virtual block devices, that means we seems to be safe for dealing with boot orders in the case that image_boot not being present
• nowadays, qemu don't even have the option (-drive ...,boot=) documented in the manual page
• -blockdev was recommended to be the replacement of -drive from several years ago and the former don't support the boot option

does it sounds good to you?