Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround bad file descriptor issue happened in postprocess #4013

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chunfuwen
Copy link
Contributor

In recent tp-libvirt testing, lots of case false warning failure happened due to ungraceful handling of postprocess cleanup in env_process.py.
Here it is workaround solution, just output error message instead of raising exception

Copy link
Contributor

@nanli1 nanli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this update, useful

Copy link
Contributor

@chloerh chloerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we set a condition to filter the file descriptor issues instead of ignoring all?

@cliping
Copy link
Contributor

cliping commented Nov 11, 2024

The bad file descriptor issue in postprocess has been fixed in #4001. And it did not appear in 103lts branch. Maybe we can close this PR.

@smitterl
Copy link
Contributor

smitterl commented Dec 4, 2024

I agree with @cliping - This should not be necessary anymore as we run our tests now with --vt-omit-data-loss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants