unattended_install: Remove the hack to get ks from providers #970
Conversation
This hack was added in a144934 to allow spice team to override the stock kickstart files, but it is actually a backdoor which picks the first matching file from any provider, no matter which provider is actually being used. Let's disallow this behavior and ask people to submit their files to the main repository. Signed-off-by: Lukáš Doktor <[email protected]>
ldoktor
force-pushed
the
remove-backdoor
branch
from
8951ace to
af0c7da
Compare
|
@Andrei-Stepanov, @clebergnu, @apahim, @will-Do would you please review this cleanup? It prevents from very unexpected and hard to debug issues. |
|
Guys, especially @Andrei-Stepanov, @clebergnu, @apahim, @will-Do, would you please comment on this? It took me long time to understand what is going on and I don't want to go into this hell ever again. |
|
@ldoktor, do the people using this know about the change? are they ready for this change? |
|
I know @Andrei-Stepanov used to be using this, which lead to hard to debug issues and we ended-up fixing it by pushing their changes upstream and renaming their custom cfgs to not collide. This is a follow-up patch to get rid of this unexpected, hard-to-debug and really slow "feature" once for all but apparently no one cares. After 10 months since the first notification and 4 months after the last one I think it's time to say they have nothing against. |
|
@ldoktor I have nothing against removing this bit. |
|
@PandaWei @xutian @apahim @clebergnu @lmr any second reviewer for this thing? (I don't want to update it without knowing it's mergable...) |
This hack was added in a144934 to allow
spice team to override the stock kickstart files, but it is actually a
backdoor which picks the first matching file from any provider, no
matter which provider is actually being used.
Let's disallow this behavior and ask people to submit their files to the
main repository.
@Andrei-Stepanov could you please take a look at this? I hope this backdoor is not needed anymore and this would be the target solution for me, anyway I'd be willing to temporarily change it to look for the file and if it does not exists look into providers files (basically change the order, first try to look in Avocado sources, then in backend dirs to allow adding extra files, but don't allow overriding existing Avocado files)