Skip to content
This repository has been archived by the owner on Sep 20, 2018. It is now read-only.

Email doesn't work #6

Open
rpadovani opened this issue Feb 7, 2016 · 1 comment
Open

Email doesn't work #6

rpadovani opened this issue Feb 7, 2016 · 1 comment
Labels

Comments

@rpadovani
Copy link

Congrats for the idea, it's very cool.

I was trying to create my CV, and it doesn't insert the email - actually, it seems there are no reference to email field in JS code...

@awalgarg awalgarg added the bug label Feb 7, 2016
@awalgarg
Copy link
Owner

awalgarg commented Feb 7, 2016

The email input is actually a left-over from my initial implementation that was much more feature hungry. The current version is a more modest approach.

The reasoning to not include email in the CV as of now is that I wasn't able to decide where exactly to put it. Further, we allow markdown in the "about" section, where a simple <[email protected]> would create a click-to-compose email.

The reasoning to include it in the original version was to automatically get a link to user's gravatar via http://avatars.io/gravatar/<emailhere> which had some issues (presence detection was... weird).

Marking this as a bug for now. Thanks for bringing it up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants