Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave ad notifications are marked as urgent in git master #3955

Closed
EXtremeExploit opened this issue Sep 17, 2024 · 1 comment
Closed

Brave ad notifications are marked as urgent in git master #3955

EXtremeExploit opened this issue Sep 17, 2024 · 1 comment

Comments

@EXtremeExploit
Copy link

EXtremeExploit commented Sep 17, 2024

Output of awesome --version:

Stable:

awesome v4.3 (Too long)
 • Compiled against Lua 5.3.6 (running with Lua 5.3)
 • D-Bus support: ✔
 • execinfo support: ✔
 • xcb-randr version: 1.6
 • LGI version: 0.9.2

git (using awesome-git aur package):

awesome v4.3-1666-gd53eb1be6-dirty (Too long)
 • Compiled against Lua 5.4.7 (running with 0.9.2)
 • API level: 4
 • D-Bus support: yes
 • xcb-errors support: yes
 • execinfo support: yes
 • xcb-randr version: 1.6
 • LGI version: /usr/share/lua/5.4/lgi/version.lua
 • Transparency enabled: yes
 • Custom search paths: no

How to reproduce the issue:

  • Open brave on awesomewm compiled with the current master branch code
  • Wait for the ad notifications to show (you need to have them enabled)
  • See how they are marked as urgent, making it so that right clicking it still executes the main action of opening the ad instead of dismissing it

Actual result:

  • Notification is red/urgent and when dismissing it opens the ad because of it

Expected result:

  • I should be able to dismiss the notification like on stable

  • NOTE: this happens mainly with the brave ads, so far i havent seen any other notification (even from brave extensions like steam inventory helper when it gets updated) with this behavior, only the ads

@actionless
Copy link
Member

#3944

@actionless actionless closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants