Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-svg 13 support #168

Closed
wants to merge 2 commits into from

Conversation

GunnarAK
Copy link

Unit tests run fine, but I haven't tested this change with the example project for reasons mentioned here: #164 (comment)

Copy link

@otech47 otech47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clean and would prevent repos that depend on this package from having to run npm install --legacy-peer-deps

@1level1
Copy link

1level1 commented Dec 9, 2022

Can we please merge this? What is missing?

@alessandrocapra
Copy link

@awesomejerry I think you're the official creator, any chance you could merge this? If help is needed let us know, but for me this is blocking the upgrade to Expo SDK 47.

@awesomejerry
Copy link
Contributor

@awesomejerry I think you're the official creator, any chance you could merge this? If help is needed let us know, but for me this is blocking the upgrade to Expo SDK 47.

I don't personally use react-native anymore. If this PR runs fine with the recent Expo version, I can merge it ASAP. Have you tried it with an example project?

@GunnarAK
Copy link
Author

GunnarAK commented Jan 9, 2023

@awesomejerry as mentioned here (#164 (comment)) I personally did not succeed with getting the example project to run in the first place.

I'm not very familiar with Expo, but it shouldn't be that hard to run an example project.

@wodin
Copy link

wodin commented Feb 18, 2023

It looks to me like this PR is no longer needed after #166 was merged

@GunnarAK GunnarAK closed this Feb 18, 2023
@GunnarAK
Copy link
Author

Fixed in #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants