Skip to content

Some countries like Angola, When selecting the type of currency is not displayed the symbol but rather the iso code. #7241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Zebedeu opened this issue May 3, 2019 · 1 comment · May be fixed by #7244
Open

Some countries like Angola, When selecting the type of currency is not displayed the symbol but rather the iso code. #7241

Zebedeu opened this issue May 3, 2019 · 1 comment · May be fixed by #7244
Labels
type-bug workflow-has-pr workflow-needs-testing

Comments

@Zebedeu
Copy link
Contributor

Zebedeu commented May 3, 2019

When selecting the currency expect an output of the currency symbol and not the ISO 4217 code.

Captura de ecrã 2019-05-03, às 03 30 03

  1. Select Angola as the base country
  2. Select Currency
  3. add a product and a price
  4. Expected output kz 25.00 and not AOA 25.00
    PHP Version:
    PHP Version 7.2

EDD Version (or branch):
EDD version 2.9.7
WordPress Version:

Wordpress Version 5.2-RC2-45280
mintplugins added a commit that referenced this issue May 3, 2019
@mintplugins
Use symbol when formatting currency for the default.
3768afa 
#7241 The edd_currency_symbol function returns the currency if no symbol is found. Therefore we can use $symbol here
@mintplugins mintplugins linked a pull request May 3, 2019 that will close this issue
Open
@mintplugins
Copy link
Contributor

@Zebedeu Thanks for the report. I confirmed the issue using your testing steps and submitted the fix for it in #7244

It fixes the issue in my tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug workflow-has-pr workflow-needs-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use symbol when formatting currency for the default. awesomemotive/easy-digital-downloads
2 participants
@mintplugins @Zebedeu