Bug Report

Expected behavior

When I add a label to an input, it should be properly associated with the input (eg: clicking on the label should move focus to the input).

Actual behavior

• When I add a label to a text field in a repeater row, the use of edd_sanitize_key in the text method strips out the [] and the label is disconnected from the field.
• The textarea method uses $args['name'] for the label; text uses $args['id']
• 3.0 adds a label to the checkbox, but it more properly uses esc_attr so that it works in repeaters
• some uses of the html-> methods define an id, but quite a few do not, and just use name
• if an id is not defined for a text field, for example, the text field will end up with no id

Steps to reproduce the behavior

1. Edit a download and enable variable pricing
2. Inspect the input fields in the Price ID row.

For the Option Name field:

• There is no label associated with the input field
• The span id is edd-edd_variable_prices1name-wrap because of the use of edd_sanitize_key
• To add a label, two parameters must be added to the field defintion: both a label and an id, or else the for will be blank and the label will not be associated with the field

Price and Default have similar issues.

Information (if a specific version is affected):

PHP Version: 7.3.5
EDD Version (or branch): master, 3.0
WordPress Version: 5.4

Any other relevant information:
As I'm working with the SL licensing addon, I'm seeing inconsistencies with how labels are added to fields--visually, most fields have some kind of visual label, but in repeatable rows especially, they're not present, which makes the inputs less accessible. This looks to be something that needs to be worked on both in Core and in extensions which use the EDD->html functions.