- In the Req track, some options use a 180s cooldown display even though its 60s
From what I can tell:
Together is listed as 60s
RaidBuffsOnly, Force, and ForceWeave are 180s
- Imperator should be usable outside melee range
Imperator can be used at range, but currently the logic requires the target to be within 3y. This can cause Imperator not to be used and drift. I think the issue may be that Requiescat and Imperator share the same planner track, but the module’s usage condition treats both as if they require melee range.
A possible fix would be to keep the same Req. track, but base the range check on BestRequiescat: use 3y when BestRequiescat is AID.Requiescat, and 25y when it is AID.Imperator.
- Blades and Holy Spirit
The blade combo can be dropped if Requiescat is no longer active, even when there are steps available.
Happens if req falls due to small downtime, but blades are still available)
Expected:
Req / Imperator required to start Confiteor.
Once the Blade combo has started, the module should continue Blade of Faith / Truth / Valor based on BladeComboStep
Holy Spirit
Currently, Divine Might Holy Spirit is spent immediately after the Atonement chain. Ideally yo want to spend Holy Spirit right before the next Royal Authority would overwrite Divine Might.
Desired behavior:
Royal Authority → Atonement → Supplication → Sepulchre → Fast Blade → Riot Blade → Holy Spirit → Royal Authority
It should still be used early if:
the player is outside melee range,
Divine Might is about to expire,
Divine Might would be overwritten by the next Royal Authority,
or the user explicitly forces Holy Spirit.
But normally DMHS should probably be held until the next combo GCD would be Royal Authority.
Ik its lowk alot- I can try to fork and submit a PR with these changes if that would be helpful.
From what I can tell:
Together is listed as 60s
RaidBuffsOnly, Force, and ForceWeave are 180s
Imperator can be used at range, but currently the logic requires the target to be within 3y. This can cause Imperator not to be used and drift. I think the issue may be that Requiescat and Imperator share the same planner track, but the module’s usage condition treats both as if they require melee range.
A possible fix would be to keep the same Req. track, but base the range check on BestRequiescat: use 3y when BestRequiescat is AID.Requiescat, and 25y when it is AID.Imperator.
The blade combo can be dropped if Requiescat is no longer active, even when there are steps available.
Happens if req falls due to small downtime, but blades are still available)
Expected:
Req / Imperator required to start Confiteor.
Once the Blade combo has started, the module should continue Blade of Faith / Truth / Valor based on BladeComboStep
Holy Spirit
Currently, Divine Might Holy Spirit is spent immediately after the Atonement chain. Ideally yo want to spend Holy Spirit right before the next Royal Authority would overwrite Divine Might.
Desired behavior:
Royal Authority → Atonement → Supplication → Sepulchre → Fast Blade → Riot Blade → Holy Spirit → Royal Authority
It should still be used early if:
the player is outside melee range,
Divine Might is about to expire,
Divine Might would be overwritten by the next Royal Authority,
or the user explicitly forces Holy Spirit.
But normally DMHS should probably be held until the next combo GCD would be Royal Authority.
Ik its lowk alot- I can try to fork and submit a PR with these changes if that would be helpful.