[Feature request] Remove dependency on docker client

[runlevel5]

From my understanding in order to perform authentication, the action utilises the docker client to perform docker login. Which is fine. However this dependency will make this plugin incompatible with environment that does not ship docker client (or users could not install any software). IMHO the action should take advantage of the HTTP API endpoint to perform this task instead.

One example I run into is that I run gitub action runners on AWS Lambda & ECS & ECS Fargate environment which lacks the docker CLI. The error output I got is:

Error: Unable to locate executable file: docker. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

[szhekpisov]

Same here, have a version v2.

[runlevel5]

I am more than happy to offer a Pull Request if the team approves this proposal

[gricey432]

I think this would also solve #434 ?

[runlevel5]

I think this would also solve #434 ?

Yes it would

[mohitgarg]

@runlevel5 is there a workaround for this? I tried using another runner but then node would fail in $PATH.

[runlevel5]

@runlevel5 is there a workaround for this? I tried using another runner but then node would fail in $PATH.

AFAIK the answer is no.

[marcindruzgala]

The issue is that HTTP API is rate limited, and the limit of http calls is very low per day - I had this issue when requesting auth token from ECR using Pulumi

[runlevel5]

The issue is that HTTP API is rate limited, and the limit of http calls is very low per day - I had this issue when requesting auth token from ECR using Pulumi

It is true but how is it different to the mechanism of docker login?

[marcindruzgala]

It is true but how is it different to the mechanism of docker login?

That I don't have answer to - I only know that I can run hundreds of jobs every day using this GitHub Action and I'm not rate limited, when I was testing building docker using Pulumi and requesting ecr credentials using http calls I started getting rate limited after few tests 🤷‍♂