Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS_SESSION_TOKEN example back to README #311

Closed
humphd opened this issue Nov 11, 2021 · 3 comments
Closed

Add AWS_SESSION_TOKEN example back to README #311

humphd opened this issue Nov 11, 2021 · 3 comments
Labels
documentation This is an issue with documentation effort/small This issue will take less than a day of effort to fix p2

Comments

@humphd
Copy link

humphd commented Nov 11, 2021

I had to use aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }} today in order to authenticate successfully, and I only discovered it via this old commit 3042b00. It looks like it got removed in b8c74de#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L30, possibly by mistake?

I think it's pretty useful to include it, and I'd suggest adding it back.

@NathanielRN
Copy link

This is probably related to #302 , because the code to make it work with OIDC is merged as you pointed out in b8c74de#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L30 but the release for it has not been made yet.

@peterwoodworth peterwoodworth added the needs-triage This issue still needs to be triaged label Oct 4, 2022
@peterwoodworth peterwoodworth added documentation This is an issue with documentation p2 effort/small This issue will take less than a day of effort to fix and removed needs-triage This issue still needs to be triaged labels Feb 21, 2023
@peterwoodworth
Copy link
Contributor

There's now an example of this in the docs

@github-actions
Copy link

** Note **
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is an issue with documentation effort/small This issue will take less than a day of effort to fix p2
Projects
None yet
Development

No branches or pull requests

3 participants