-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error object is empty breaking action #395
Comments
Seems to be kinda temperamental. Is working again now. |
I've also seen this happen a couple of times today but not consistently. A search (https://github.com/aws-actions/configure-aws-credentials/search?q=message) indicates that this could be an error masking another error? Edit: Also seeing this when assuming a role via OIDC. |
Same problem here... do you have any ideas where to dig into the source.. oder what to do to make it more stable or get closer to the cause of the problem? |
- insights absolutely missing... - actions fails sporadically with a "message not found" error - currently watching aws-actions#395 - also fix a bug in the unit test (guess it was changed but not executed some time...) KNUTH-66633
- insights absolutely missing... - actions fails sporadically with a "message not found" error - currently watching aws-actions#395 - also fix a bug in the unit test (guess it was changed but not executed some time...) KNUTH-66633
We're observing same flaky behaviour as of today (assuming role via OIDC). Currently we can't locate the problem and think that it's belonging to the runners - we're using default runners. One run fails, the next one again works. Very strange. |
Wild guessing here, but I noticed that while adding Github as OIDC provider in AWS, that I get different SSL Certificate thumbprints, such as:
There is also an open issue here #357 (but the error message compared to that issue is more on point) TLDR: You might should take a look at your thumbprint and add 693... to the list, if its not already there. |
The issue described here must be intermittent. |
We are also having this flaky behaviour while assuming roles with OIDC |
Experiencing flaky behaviour assuming role via OIDC. |
I'm going to also request that people share their full workflow files if possible. It seems this is limited to OIDC which is helpful to know 🙂 |
We are having a similar experience, using
Cleaned log:
|
We are also seeing it using oidc |
We're also getting intermittent failures with OIDC. It's working the majority of the time though. I don't see any logs in AWS CloudTrail for an attempted OIDC login around the time of the error. Workflow: - name: Configure AWS Credentials
uses: aws-actions/[email protected]
with:
role-to-assume: // our IAM role ARN
aws-region: // our AWS region Output:
|
I also encountered this today in a workflow that has many parallel jobs that independently authed with AWS successfully - just the one job failed. I suspect that something is being raised in I haven't any information on where this is being thrown from, but have enabled In the meantime, perhaps the team can change the catch-all Here's my unhelpful log :)
|
- insights absolutely missing... - actions fails sporadically with a "message not found" error - currently watching aws-actions#395 - also fix a bug in the unit test (guess it was changed but not executed some time...) KNUTH-66633
Hi, we are also experiencing this issue and enabled the
After examining the code it seems to be thrown in the
|
I've opened an issue on the Github toolkit where the OIDC client is defined |
We have the same issue, with oidc and self hosted runners. Every time we restart the failed workflow, it works. |
Its been failing intermittently pretty much every day and it does seem to happen more frequently Do you plan to re-priortise and assign someone to do more proper investigation ? the workflow file is super simple:
|
I can second that. For a few days it became more frequent now. @lkeijmel can you share the issue here maybe? |
GitHub has been having some intermittent issues the past couple days, any increased errors could be due to that. We are nearing a v3 release, some stuff has to get sorted out first internally so I can't give any dates. I doubt this error would stop in v3 though, since we aren't changing the way we're using I've never been able to reproduce it, so I haven't been able to really investigate it. Hopefully the issue @lkeijmel opened in the |
@lmeynberg here's the issue actions/toolkit#1441 |
For now I've forked this repo, added some additional logging in and around the |
We've deploying without any issues so far this week, only a expired security token error sometimes but than was due to a longer run and a short TTL on the token itself. I just saw that github has written a blogpost regarding some OIDC issues which can be related to this: https://github.blog/changelog/2023-06-27-github-actions-update-on-oidc-integration-with-aws/ |
This went away with the thumbprint change, but started happening again today. @lkeijmel can you also see the issue on your side? |
We don't see it currently on our deployments. After the blog post of the GH team we double checked the fingerprints but still no failures. |
I don't think this issue is related to the fingerprints issue, this error would occur before it gets a chance to send the request to the IDP if it's coming from the We've implemented the retry and backoff on the |
I just saw a blogpost from Github stating that pinning is no longer required and shouldn't be the issue. |
We now implement a retry behavior when the |
I've subscribed to the issue @lkeijmel created, so I'll be up to date if there's any update there. Otherwise, I think the retry behavior on the token in |
** Note ** |
Action stopped working today, after working for multiple weeks:
The text was updated successfully, but these errors were encountered: