Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes to documentation about Enterprise #727

Closed
juliusoh opened this issue May 16, 2023 · 5 comments
Closed

Add notes to documentation about Enterprise #727

juliusoh opened this issue May 16, 2023 · 5 comments
Labels
bug Something isn't working documentation This is an issue with documentation effort/small This issue will take less than a day of effort to fix p2

Comments

@juliusoh
Copy link

juliusoh commented May 16, 2023

Describe the bug

I have
- uses: aws-actions/configure-aws-credentials@v2 with: aws-region: ${{ secrets.AWS_REGION }} role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} role-session-name: "TerraformPlan"

It throws an error

Error: No OpenIDConnect provider found in your account for https://github.MYORG.net/_services/token

Expected Behavior

I expect it to successfully assume role. OIDC provider and Role was successfully created in AWS.

Current Behavior

The error is thrown

Reproduction Steps

Create OIDC provider for GIthub enterprise account

Possible Solution

No response

Additional Information/Context

No response

@juliusoh juliusoh added bug Something isn't working needs-triage This issue still needs to be triaged labels May 16, 2023
@peterwoodworth peterwoodworth added p2 and removed needs-triage This issue still needs to be triaged labels May 24, 2023
@funes79
Copy link

funes79 commented May 26, 2023

I have a similar issue. I have a setup where the IAM role was correctly working. Then today it throw the error message.

No OpenIDConnect provider found in your account for https://token.actions.githubusercontent.com/

Not sure if this is kind of a temporary outage, https://www.githubstatus.com/ shows everything green now, I tried to rerun the flow with a newer version (v2), same result.

Update: it works from me on main branch but not in dev branch (the two branches are "connected" to different AWS accounts)

Update: my provider in AWS account has been changed or deleted. So problem solved on my side.

@kchandra548
Copy link

@juliusoh As you are using GHES instance, by default OIDC endpoints are internal and not accessible from outside. So you need to expose following endpoints to the internet(public)
https://github.myorg.net/_services/token/.well-known/openid-configuration
https://github.myorg.net/_services/token/.well-known/jwks

@peterwoodworth
Copy link
Contributor

Good catch @kchandra548, the enterprise OIDC endpoint is different than normal. See the documentation on GitHub here on how to configure your identity provider when using Enterprise Server

@peterwoodworth peterwoodworth added the documentation This is an issue with documentation label Jun 13, 2023
@peterwoodworth peterwoodworth changed the title No OpenIDConnect Provider found Add notes to documentation about Enterprise Jun 13, 2023
@peterwoodworth peterwoodworth added the effort/small This issue will take less than a day of effort to fix label Jun 13, 2023
@peterwoodworth
Copy link
Contributor

Added short note about enterprise https://github.com/aws-actions/configure-aws-credentials#note-about-ghes

@github-actions
Copy link

** Note **
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation This is an issue with documentation effort/small This issue will take less than a day of effort to fix p2
Projects
None yet
Development

No branches or pull requests

4 participants