Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: masking of account ID is unclear #801

Closed
cloudshiftchris opened this issue Aug 25, 2023 · 2 comments
Closed

README: masking of account ID is unclear #801

cloudshiftchris opened this issue Aug 25, 2023 · 2 comments
Labels
bug Something isn't working documentation This is an issue with documentation p2

Comments

@cloudshiftchris
Copy link

cloudshiftchris commented Aug 25, 2023

Describe the issue

In the README it states:

By default, your account ID will not be masked in workflow logs. This was changed from being masked by default in the previous version. AWS does consider account IDs as sensitive information, so this change reflects that stance. You can revert to the old default and mask your account ID in workflow logs by setting the mask-aws-account-id input to true.

...which has these contradictory statementst:

  • account ID will NOT be masked;
  • AWS DOES consider account IDs as sensitive information

Further in the README it states:

Your account ID is not masked by default in workflow logs since it's not considered sensitive information.

From the default behaviour presumably AWS does NOT consider account IDs as sensitive; the initial statement is incorrect.

@cloudshiftchris cloudshiftchris added documentation This is an issue with documentation needs-triage This issue still needs to be triaged labels Aug 25, 2023
@kellertk
Copy link
Contributor

You're correct. This was simply a typo that we missed during review, fixed with #799. Thanks for reporting!

@kellertk kellertk added bug Something isn't working p2 and removed needs-triage This issue still needs to be triaged labels Aug 25, 2023
@github-actions
Copy link

** Note **
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation This is an issue with documentation p2
Projects
None yet
Development

No branches or pull requests

2 participants