Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretAccessKey contains special characters #821

Closed
shaylevin89 opened this issue Sep 4, 2023 · 4 comments
Closed

SecretAccessKey contains special characters #821

shaylevin89 opened this issue Sep 4, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@shaylevin89
Copy link

Describe the bug

when I try to assume a role it works usually. BUT sometimes I get error
usually works

Expected Behavior

  1. this will not happen
  2. if it happens it should be more informative. like which character is not allowed. and maybe the option to choose accepted charecters

Current Behavior

when I try to assume a role it usually works. BUT sometimes I get this error:
Error: Could not assume role with OIDC: SecretAccessKey contains special characters.
this behaviour happens 1 time every ~100 runs.

Reproduction Steps

there is no such. its happen randomly

Possible Solution

No response

Additional Information/Context

No response

@shaylevin89 shaylevin89 added bug Something isn't working needs-triage This issue still needs to be triaged labels Sep 4, 2023
@peterwoodworth peterwoodworth removed the needs-triage This issue still needs to be triaged label Sep 5, 2023
@peterwoodworth
Copy link
Contributor

Are you using v3? This functionality should be disabled by default. Please provide your workflow file?

@peterwoodworth peterwoodworth added the response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 5 days. label Sep 5, 2023
@shaylevin89
Copy link
Author

thanks for the reply. we r using v3.0.0.
we r using this action via another composite action. this is the composite action:

runs:
using: "composite"
steps:
- name: configure aws credentials for dev
uses: aws-actions/[email protected]
with:
role-to-assume: arn:aws:iam:::role/**
role-session-name: GitHub_to_AWS_via_FederatedOIDC
aws-region: ${{ env.AWS_SECRET_REGION }}

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 5 days. label Sep 6, 2023
@shaylevin89
Copy link
Author

I changed the version to v3 and added the special-characters-workaround: true. and lets see if it will happen again. thanks

@kellertk kellertk closed this as completed Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants