From 97ab9a9e0c0bcdb7d92cefee7e986f0b8d403a85 Mon Sep 17 00:00:00 2001 From: Adrian Miranda Date: Wed, 22 Feb 2023 23:01:59 +0800 Subject: [PATCH 1/2] removed self reference in nodejs vn --- cdk/cdk/nodejsservice.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cdk/cdk/nodejsservice.py b/cdk/cdk/nodejsservice.py index 13cf730..eafe5e5 100644 --- a/cdk/cdk/nodejsservice.py +++ b/cdk/cdk/nodejsservice.py @@ -235,7 +235,7 @@ def appmesh(self): # Adding mesh virtual service self.mesh_nodejs_vs = aws_appmesh.VirtualService(self, "mesh-nodejs-vs", virtual_service_provider=aws_appmesh.VirtualServiceProvider.virtual_node( - self.mesh_nodejs_vn), + mesh_nodejs_vn), virtual_service_name="{}.{}".format( self.fargate_service.cloud_map_service.service_name, self.fargate_service.cloud_map_service.namespace.namespace_name) ) From 713da006efde539f7735c2cf0626debb44b75599 Mon Sep 17 00:00:00 2001 From: Adrian Miranda Date: Thu, 23 Feb 2023 11:26:27 +0800 Subject: [PATCH 2/2] to make the sed work --- cdk/cdk/nodejsservice.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cdk/cdk/nodejsservice.py b/cdk/cdk/nodejsservice.py index eafe5e5..96df7a6 100644 --- a/cdk/cdk/nodejsservice.py +++ b/cdk/cdk/nodejsservice.py @@ -29,7 +29,7 @@ def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None: compatibility=aws_ecs.Compatibility.EC2_AND_FARGATE, cpu='256', memory_mib='512', - # appmesh-proxy-uncomment + #appmesh-proxy-uncomment # proxy_configuration=aws_ecs.AppMeshProxyConfiguration( # container_name="envoy", # App Mesh side card name that will proxy the requests # properties=aws_ecs.AppMeshProxyConfigurationProps( @@ -41,7 +41,7 @@ def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None: # ignored_uid=1337 # side card default config # ) # ) - # appmesh-proxy-uncomment + #appmesh-proxy-uncomment ) log_group = aws_logs.LogGroup(