Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Declaration of objects before usage #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Declaration of objects before usage #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions cdk/cdk/nodejsservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,11 @@ def appmesh(self):
# self.fargate_task_def.task_role.add_managed_policy(aws_iam.ManagedPolicy.from_aws_managed_policy_name("AWSXRayDaemonWriteAccess"))
self.fargate_task_def.task_role.add_managed_policy(
aws_iam.ManagedPolicy.from_aws_managed_policy_name("AWSAppMeshEnvoyAccess"))


self.mesh = mesh
self.mesh_vgw = mesh_vgw
self.mesh_nodejs_vn = mesh_nodejs_vn
self.envoy_container = envoy_container
# Adding mesh virtual service
self.mesh_nodejs_vs = aws_appmesh.VirtualService(self, "mesh-nodejs-vs",
virtual_service_provider=aws_appmesh.VirtualServiceProvider.virtual_node(
Expand All @@ -246,8 +250,8 @@ def appmesh(self):
CfnOutput(self, "MeshNodeJsVSName",
value=self.mesh_nodejs_vs.virtual_service_name, export_name="MeshNodeJsVSName")

self.mesh = mesh
self.mesh_vgw = mesh_vgw
self.mesh_nodejs_vn = mesh_nodejs_vn
self.envoy_container = envoy_container
# self.mesh = mesh
# self.mesh_vgw = mesh_vgw
# self.mesh_nodejs_vn = mesh_nodejs_vn
# self.envoy_container = envoy_container
# self.xray_container = xray_container