Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a github repo to PR against books.json for the demo? #2

Open
QuinnyPig opened this issue Dec 6, 2018 · 3 comments
Open

Is there a github repo to PR against books.json for the demo? #2

QuinnyPig opened this issue Dec 6, 2018 · 3 comments

Comments

@QuinnyPig
Copy link

QuinnyPig commented Dec 6, 2018

There are several great books that could be added to the sample dataset, including such classics as:

The Invisible TAM
The Book of Job Scheduling
Stranger in a Strange LAN
20000 Leagues Under the C
The Site Down and the Fury
Prometheus IO Bound
A Cloud Flew Over the Cuckoo’s Nest
The Callback of the Wild
A Song of Ice and Tirefire
Senders Game
All Quiet on the Western Cloudfront
Infinite Jeffs
JSON and the Golden Fleece
The Segfault in Our Stars
Us-East-1 of Eden
The Datalakes of Wrath
Paradise Tossed
The Sun Also Crashes
The Old Man and the C

@stevensideyliu
Copy link

Hello! You may deploy the bookstore demo and populate it with your own books. However, we want to avoid adding books to the sample dataset that will have copy write implications to this project. The current books in the sample dataset are faux books with faux authors.

@drmudgett
Copy link

@QuinnyPig - I believe that the problem is that you've only added more faux books to the list. @stevensideyliu probably needs you to add the faux authors to be able to accept a PR.

@adamchainz
Copy link

Some more:

  • The Strange Case of Jekyll and Github Pages
  • Uly C's
  • Brave Re:invented World
  • Charlotte's Website
  • A Tale of Two Regions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants