Template and instructions are not correct

[timpugh]

https://github.com/aws-samples/serverless-patterns/blame/857fb76f4c5b908c91b44ca1c2db7bdc364b82ac/rabbitmq-lambda/template.yaml#L17

MQAccess should have a lower case "a" (MQaccess) to match what is created in the instructions:

serverless-patterns/rabbitmq-lambda/README.md

Line 20 in 857fb76

aws secretsmanager create-secret --name MQaccess --secret-string '{"username": "your-username", "password": "your-password"}'

Else you'll get into an obscure error that CloudTrail wont have an event for during the CloudFormation deployment where it mentions "the secret can't be found".

Also: the instructions should mention the password length must be at least 12-250 chars long.

[timpugh]

Also the version in the template is old and no longer valid: https://github.com/aws-samples/serverless-patterns/blame/857fb76f4c5b908c91b44ca1c2db7bdc364b82ac/rabbitmq-lambda/template.yaml#L13

EngineVersion: "3.13" should work, but then you'll also need to set this property: https://github.com/aws-samples/serverless-patterns/blame/857fb76f4c5b908c91b44ca1c2db7bdc364b82ac/rabbitmq-lambda/template.yaml#L9

to true

I'll summarize the notes:

1.) line 17 of the template should have MQaccess with a lower case a for access to match the secret that is created in the extended tutorial

2.) The README should mention at the secret creation step that the password needs to be between 12-250 chars in length

3.) Broker engine should be changed...3.13 works but you'll also need to set AutoMinorVersionUpgrade to true

[julianwood]

Thanks Tim. Would you mind submitting a PR with the changes and we an ensure its all correct with your good eyes!