Skip to content

Commit acc06d6

Browse files
authored
fix: setQueryTimeout for mysql2DriverDialect (#393)
1 parent 09f4931 commit acc06d6

6 files changed

+11
-10
lines changed

common/lib/client_wrapper.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export interface ClientWrapper {
2222
readonly properties: Map<string, any>;
2323
readonly id: string;
2424

25-
query(sql: any): Promise<any>;
25+
query(sql: string): Promise<any>;
2626

2727
end(): Promise<void>;
2828

common/lib/mysql_client_wrapper.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,10 @@ export class MySQLClientWrapper implements ClientWrapper {
4646
this.id = uniqueId("MySQLClient_");
4747
}
4848

49-
query(sql: any): Promise<any> {
50-
this.driverDialect.setQueryTimeout(this.properties, sql);
51-
return this.client?.query(sql);
49+
query(sql: string): Promise<any> {
50+
const query = { sql: sql };
51+
this.driverDialect.setQueryTimeout(this.properties, query);
52+
return this.client?.query(query);
5253
}
5354

5455
async queryWithTimeout(sql: string): Promise<any> {

common/lib/pg_client_wrapper.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export class PgClientWrapper implements ClientWrapper {
4141
this.id = uniqueId("PgClient_");
4242
}
4343

44-
query(sql: any): Promise<any> {
44+
query(sql: string): Promise<any> {
4545
return this.client?.query(sql);
4646
}
4747

common/lib/pool_client_wrapper.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export class PoolClientWrapper implements ClientWrapper {
3838
return this.end();
3939
}
4040

41-
query(sql: any): Promise<any> {
41+
query(sql: string): Promise<any> {
4242
return this.client?.query(sql);
4343
}
4444

mysql/lib/dialect/mysql2_driver_dialect.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,10 @@ export class MySQL2DriverDialect implements DriverDialect {
6868
}
6969
}
7070

71-
setQueryTimeout(props: Map<string, any>, sql?: any, wrapperConnectTimeout?: any) {
72-
const timeout = wrapperConnectTimeout ?? props.get(WrapperProperties.WRAPPER_QUERY_TIMEOUT.name);
71+
setQueryTimeout(props: Map<string, any>, sql?: any, wrapperQueryTimeout?: any) {
72+
const timeout = wrapperQueryTimeout ?? props.get(WrapperProperties.WRAPPER_QUERY_TIMEOUT.name);
7373
if (timeout && !sql[MySQL2DriverDialect.QUERY_TIMEOUT_PROPERTY_NAME]) {
74-
sql[MySQL2DriverDialect.QUERY_TIMEOUT_PROPERTY_NAME] = timeout;
74+
sql[MySQL2DriverDialect.QUERY_TIMEOUT_PROPERTY_NAME] = Number(timeout);
7575
}
7676
}
7777

mysql/lib/dialect/mysql_database_dialect.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export class MySQLDatabaseDialect implements DatabaseDialect {
120120
try {
121121
return await ClientUtils.queryWithTimeout(
122122
targetClient
123-
.query({ sql: "SELECT 1" })
123+
.query("SELECT 1")
124124
.then(() => {
125125
return true;
126126
})

0 commit comments

Comments
 (0)