From c5723320872c4b6f0ca1b2eb57ff19d44d0180e2 Mon Sep 17 00:00:00 2001 From: Karen Chen Date: Mon, 3 Feb 2025 10:40:40 -0800 Subject: [PATCH] fix: error retrieving keep alive settings --- mysql/lib/dialect/mysql2_driver_dialect.ts | 2 +- pg/lib/dialect/node_postgres_driver_dialect.ts | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mysql/lib/dialect/mysql2_driver_dialect.ts b/mysql/lib/dialect/mysql2_driver_dialect.ts index 61b9003d..fd59616a 100644 --- a/mysql/lib/dialect/mysql2_driver_dialect.ts +++ b/mysql/lib/dialect/mysql2_driver_dialect.ts @@ -76,7 +76,7 @@ export class MySQL2DriverDialect implements DriverDialect { } setKeepAliveProperties(props: Map, keepAliveProps: any) { - if (keepAliveProps && keepAliveProps.get(MySQL2DriverDialect.KEEP_ALIVE_PROPERTY_NAME)) { + if (keepAliveProps && keepAliveProps[MySQL2DriverDialect.KEEP_ALIVE_PROPERTY_NAME] !== undefined) { throw new UnsupportedMethodError("Keep alive configuration is not supported for MySQL2."); } } diff --git a/pg/lib/dialect/node_postgres_driver_dialect.ts b/pg/lib/dialect/node_postgres_driver_dialect.ts index dc23f28d..47b643df 100644 --- a/pg/lib/dialect/node_postgres_driver_dialect.ts +++ b/pg/lib/dialect/node_postgres_driver_dialect.ts @@ -83,13 +83,13 @@ export class NodePostgresDriverDialect implements DriverDialect { return; } - const keepAlive = keepAliveProps.get(NodePostgresDriverDialect.KEEP_ALIVE_PROPERTY_NAME); - const keepAliveInitialDelayMillis = keepAliveProps.get(NodePostgresDriverDialect.KEEP_ALIVE_INITIAL_DELAY_MILLIS_PROPERTY_NAME); + const keepAlive = keepAliveProps[NodePostgresDriverDialect.KEEP_ALIVE_PROPERTY_NAME]; + const keepAliveInitialDelayMillis = keepAliveProps[NodePostgresDriverDialect.KEEP_ALIVE_INITIAL_DELAY_MILLIS_PROPERTY_NAME]; - if (keepAlive) { + if (keepAlive !== undefined) { props.set(NodePostgresDriverDialect.KEEP_ALIVE_PROPERTY_NAME, keepAlive); } - if (keepAliveInitialDelayMillis) { + if (keepAliveInitialDelayMillis !== undefined) { props.set(NodePostgresDriverDialect.KEEP_ALIVE_INITIAL_DELAY_MILLIS_PROPERTY_NAME, keepAliveInitialDelayMillis); } }