Skip to content

Commit 472069b

Browse files
BennettJamesBennett Sala
andauthored
Preserve grpc port value from crd (#711)
* Release v1.12.1 * Preserve grpc match port value for crd value conversion --------- Co-authored-by: Bennett Sala <[email protected]>
1 parent bf319eb commit 472069b

File tree

6 files changed

+8
-7
lines changed

6 files changed

+8
-7
lines changed

config/helm/appmesh-controller/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
apiVersion: v1
22
name: appmesh-controller
33
description: App Mesh controller Helm chart for Kubernetes
4-
version: 1.12.0
5-
appVersion: 1.12.0
4+
version: 1.12.1
5+
appVersion: 1.12.1
66
home: https://github.com/aws/eks-charts
77
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
88
sources:

config/helm/appmesh-controller/ci/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ accountId: 123456789
55
region: us-west-2
66
image:
77
repository: public.ecr.aws/appmesh/appmesh-controller
8-
tag: v1.12.0
8+
tag: v1.12.1
99
pullPolicy: IfNotPresent

config/helm/appmesh-controller/test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ useAwsFIPSEndpoint: false
1212

1313
image:
1414
repository: 840364872350.dkr.ecr.us-west-2.amazonaws.com/amazon/appmesh-controller
15-
tag: v1.12.0
15+
tag: v1.12.1
1616
pullPolicy: IfNotPresent
1717

1818
sidecar:

config/helm/appmesh-controller/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ useAwsFIPSEndpoint: false
1313

1414
image:
1515
repository: 840364872350.dkr.ecr.us-west-2.amazonaws.com/amazon/appmesh-controller
16-
tag: v1.12.0
16+
tag: v1.12.1
1717
pullPolicy: IfNotPresent
1818

1919
sidecar:

pkg/conversions/virtualrouter_types_conversion.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,8 +333,8 @@ func Convert_CRD_GRPCRouteMatch_To_SDK_GrpcRouteMatch(crdObj *appmesh.GRPCRouteM
333333
sdkObj.Metadata = sdkMetadataList
334334
sdkObj.MethodName = crdObj.MethodName
335335
sdkObj.ServiceName = crdObj.ServiceName
336+
sdkObj.Port = crdObj.Port
336337
return nil
337-
338338
}
339339

340340
func Convert_CRD_GRPCRouteAction_To_SDK_GrpcRouteAction(crdObj *appmesh.GRPCRouteAction,

pkg/conversions/virtualrouter_types_conversion_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1453,8 +1453,8 @@ func TestConvert_CRD_GRPCRouteMatch_To_SDK_GrpcRouteMatch(t *testing.T) {
14531453
},
14541454
MethodName: aws.String("stream"),
14551455
ServiceName: aws.String("foo.foodomain.local"),
1456+
Port: aws.Int64(9090),
14561457
},
1457-
14581458
sdkObj: &appmeshsdk.GrpcRouteMatch{},
14591459
scope: nil,
14601460
},
@@ -1491,6 +1491,7 @@ func TestConvert_CRD_GRPCRouteMatch_To_SDK_GrpcRouteMatch(t *testing.T) {
14911491
},
14921492
MethodName: aws.String("stream"),
14931493
ServiceName: aws.String("foo.foodomain.local"),
1494+
Port: aws.Int64(9090),
14941495
},
14951496
},
14961497
{

0 commit comments

Comments
 (0)