feat(ecs-patterns): add missing NLB task image options

[nmussy]

Issue # (if applicable)

Closes #30760.

Reason for this change

The ECS patterns L3 allows to create a load balanced Fargate or EC2 task, and to customize their run options. ALB task patterns implemented additional properties that NLB didn't.

Description of changes

• Add command, entryPoint props to NetworkLoadBalancedFargateService and NetworkLoadBalancedEc2Service
• Add healthCheck prop to NetworkLoadBalancedFargateService
  • I assume there's a good reason why, but I can't find out why healthChecks are only exposed for Fargate targets

Description of how you validated changes

No unit or integ were added/updated

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[nmussy]

Exemption Request: The current coverage of ECS pattern tasks isn't great, both for ALB and NLB. I don't think it's pertinent to add a couple of tests for these props, it would be a lot more pertinent to redo the entire classes

Regarding the README, I don't think these props need to be listed

[godwingrs22]

Thanks @nmussy for the contribution. It would be good to have unit tests and integ test for these properties similar to ALB EC2 and Fargate services. It is ok not to update README for these props, but would recommend to have the testcases.

[godwingrs22]

I see similar properties available in ApplicationLoadBalancedFargateService and since we are adding the same to NetworkLoadBalancedFargateService, I would recommend we have some unit test that covers these properties. We could have some testcases similar to these in ApplicationLoadBalancedFargateService.

[godwingrs22]

Similarly we should have some unit tests for these commands in NetworkLoadBalancedEc2Service. We have some similar test cases for ApplicationLoadBalancedEc2Service.

[godwingrs22]

Also we need integ test that can test these properties for NetworkLoadBalancedEc2Service and NetworkLoadBalancedFargateService. We have similar for ALB here for EC2 and Fargate

[nmussy]

@godwingrs22 Seems like coverage for ecs-patterns was improved since this PR was originally opened a few months ago. I'll update it 👍

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (5a830a0) to head (291a461).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #30775   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files         223      223           
  Lines       13727    13727           
  Branches     2411     2411           
=======================================
  Hits        11175    11175           
  Misses       2274     2274           
  Partials      278      278           

Flag	Coverage Δ
suite.unit	81.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	80.74% <ø> (ø)
packages/aws-cdk-lib/core	82.10% <ø> (ø)

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 291a461
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository