Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lambda): add note on potential errors when updating lambda functions #32838

Merged
merged 7 commits into from
Jan 17, 2025

Conversation

evzzk
Copy link
Contributor

@evzzk evzzk commented Jan 10, 2025

Issue # (if applicable)

Closes #.

Reason for this change

When you update multiple aspects of a Lambda function by modifying an aws-cdk-lib.aws-lambda L2 construct and deploying in a single CDK deployment, you may encounter a short period of time where errors occur due to all aspects not being updated together.

Description of changes

Add documentation in aws-cdk-lib.aws-lambda to explain this potential situation.

Describe any new or updated permissions being added

None

Description of how you validated changes

None. Only updated README.md

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 10, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 10, 2025 18:28
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (8c1be1e) to head (fd44efc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32838   +/-   ##
=======================================
  Coverage   81.44%   81.44%           
=======================================
  Files         225      225           
  Lines       13702    13702           
  Branches     2404     2404           
=======================================
  Hits        11160    11160           
  Misses       2267     2267           
  Partials      275      275           
Flag Coverage Δ
suite.unit 81.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.81% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 10, 2025
gracelu0
gracelu0 previously approved these changes Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jan 14, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@moelasmar
Copy link
Contributor

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jan 14, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot dismissed gracelu0’s stale review January 17, 2025 22:38

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 17, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 17, 2025
Copy link
Contributor

mergify bot commented Jan 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain merged commit 6c5accd into aws:main Jan 17, 2025
16 of 19 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

Copy link
Contributor

mergify bot commented Jan 17, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #32838 has been dequeued, merge conditions unmatch:

  • -closed
  • -merged
  • status-success~=AWS CodeBuild us-east-1
  • any of [🛡 GitHub branch protection]:
    • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge|no-squash)
  • -title~=(WIP|wip)
  • base!=release
  • status-success=validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-success = validate-pr
    • check-neutral = validate-pr
    • check-skipped = validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/patch/packages/aws-cdk
    • check-neutral = codecov/patch/packages/aws-cdk
    • check-skipped = codecov/patch/packages/aws-cdk
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/project/packages/aws-cdk
    • check-neutral = codecov/project/packages/aws-cdk
    • check-skipped = codecov/project/packages/aws-cdk
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/patch/packages/aws-cdk-lib/core
    • check-neutral = codecov/patch/packages/aws-cdk-lib/core
    • check-skipped = codecov/patch/packages/aws-cdk-lib/core
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/project/packages/aws-cdk-lib/core
    • check-neutral = codecov/project/packages/aws-cdk-lib/core
    • check-skipped = codecov/project/packages/aws-cdk-lib/core

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fd44efc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants