fix(lambda-nodejs): do not require a frozen lockfile for bun #32908
Conversation
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
blimmer
changed the title
| @@ -10,7 +10,7 @@ const stack = new cdk.Stack(app, 'TestStack'); | |||
|
|
|||
| const handler = new lambda.NodejsFunction(stack, 'Function', { | |||
| entry: path.join(__dirname, 'integ-handlers/bun/dependencies-bun.ts'), | |||
| runtime: Runtime.NODEJS_20_X, | |||
| runtime: Runtime.NODEJS_22_X, | |||
There was a problem hiding this comment.
Just bumped this to make the PR linter happy and to force re-run the integration test.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32908 +/- ##
=======================================
Coverage 81.41% 81.41%
=======================================
Files 223 223
Lines 13721 13721
Branches 2416 2416
=======================================
Hits 11171 11171
Misses 2271 2271
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
Issue #32906
Closes #32906.
Reason for this change
When I implemented
bunsupport, I accidentally used--frozen-lockfile, which caused issues when the lockfile contained additional entries other than what's being bundled in the docker container.The issue has a small repro-case.
Description of changes
I removed the
--frozen-lockfileflag, which resolved the problem.Describe any new or updated permissions being added
N/A
Description of how you validated changes
I added an additional package to the
bun.lockbfile in the integration test. This caused the issue to occur in the test suite. Once I made the changes in this PR, the test started passing again.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license