Core: CfnCodeDeployBlueGreenHook TestTrafficRoute LogicalID cant be empty or undefined.

[MattJKirby]

Describe the bug

The documentation for the CfnCodeDeployBlueGreenHook states that the test listener for the TrafficRoutingConfig object is optional. Furthermore the blue-green-hook-syntax example states the LogicalID for the TestTrafficRoute is not required.

However, the testTrafficRoute type does not allow undefined as a value, and when I provide an empty string I get the following error in my AWS CloudFormation stack:

Invalid CloudFormation template: Logical Resource ID cannot be empty

Regression Issue

• Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

I can specify undefined or “” for the TestTrafficRoute LogicalID, when no aws::ElasticLoadBalancingV2::Listener test listener Is required.

Current Behavior

I get the following error in my AWS CloudFormation stack:

Invalid CloudFormation template: Logical Resource ID cannot be empty

Reproduction Steps

Recreate the CfnCodeDeployBlueGreenHook template example in cdk, and try to specify ”” for the testTrafficRoute LogicalID

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.164.1

Framework Version

No response

Node.js Version

v20.18.0

OS

MacOS

Language

TypeScript

Language Version

TypeScript (4.9.4)

Other information

No response

[pahud]

Invalid CloudFormation template: Logical Resource ID cannot be empty

if cloudformation is throwing this error, it seems CFN just doesn't allow it to be empty.

Are you able to provide a tiny self-contained code snippet in this issue so I can rapidly reproduce it?

[MattJKirby]

Invalid CloudFormation template: Logical Resource ID cannot be empty

if cloudformation is throwing this error, it seems CFN just doesn't allow it to be empty.

Are you able to provide a tiny self-contained code snippet in this issue so I can rapidly reproduce it?

Hi, apologies, setup for this issue can be quite involved. Here is an example of the CfnCodeDeployBlueGreenHook:

const ecsServiceBlueGreenDeploymentHook = new CfnCodeDeployBlueGreenHook(this, 'EcsServiceBlueGreenDeploymentHook', {
            serviceRole: this.getLogicalId(ecsServiceBlueGreenDeploymentHookServiceRole.node.defaultChild as CfnRole),
            trafficRoutingConfig: {
                type: CfnTrafficRoutingType.TIME_BASED_CANARY,
                timeBasedCanary: {
                    stepPercentage: 15,
                    bakeTimeMins: 5
                }
            },
            applications: [
                {
                    target: {
                        type: 'AWS::ECS::Service',
                        logicalId: 'Service'
                    },
                    ecsAttributes: {
                        taskDefinitions: [
                            this.getLogicalId(blueTaskDefinition.node.defaultChild as CfnTaskDefinition),
                            'GreenTaskDefinition'
                        ],
                        taskSets: [
                            blueTaskSet.logicalId,
                            'GreenTaskSet'
                        ],
                        trafficRouting: {
                            prodTrafficRoute: {
                                type: 'AWS::ElasticLoadBalancingV2::Listener',
                                logicalId: this.getLogicalId(prodListener.node.defaultChild as CfnListener)
                            },
                            testTrafficRoute: {
                                type: 'AWS::ElasticLoadBalancingV2::Listener',
                                logicalId: 'TestListener'
                            },
                            targetGroups: [
                                this.getLogicalId(blueTargetGroup.node.defaultChild as CfnTargetGroup),
                                'GreenTargetGroup'
                            ]
                        }
                    }
                }
            ]
        })

• A more complete stack and usage of this hook can be found in this repo here. Thanks!