feat(cloudfront-origins): read versioned access level #33038
+31,723
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
effort/medium
aws-cdk-automation
previously requested changes
Jan 21, 2025
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33038 +/- ##
=======================================
Coverage 81.49% 81.49%
=======================================
Files 224 224
Lines 13755 13755
Branches 2413 2413
=======================================
Hits 11209 11209
Misses 2273 2273
Partials 273 273
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matthiasgubler
force-pushed
the
33034-add-versioned-access
branch
from
7aaae57 to
ba38355
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
matthiasgubler
commented
Jan 22, 2025
packages/aws-cdk-lib/aws-cloudfront-origins/lib/s3-bucket-origin.ts
Outdated
Show resolved
Hide resolved
matthiasgubler
force-pushed
the
33034-add-versioned-access
branch
from
ba38355 to
8b6d00d
Compare
This allows creating an S3 bucket origin OriginAccessControl for access of versioned objects Fixes aws#33034
matthiasgubler
force-pushed
the
33034-add-versioned-access
branch
from
8b6d00d to
51ce2c9
Compare
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #33034
Reason for this change
This allows creating an S3 bucket origin OriginAccessControl for access of versioned objects via CloudFront.
Description of changes
Added a new
AccessLevel.READ_VERSIONED, to extend the list of the OAC access levels, which extends the S3 bucket policy to contains3:GetObjectVersion. I followed the existing patterns for the different AccessLevels, to make the change as small as possible.This enables versioned S3 bucket origins to allow the CloudFront distribution to access object versions.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Added a new unit-test and a new integration test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license