Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --s3-endpoint-url argument to cloudformation package #4727

Closed
miron4dev opened this issue Dec 3, 2019 · 6 comments
Closed

Support --s3-endpoint-url argument to cloudformation package #4727

miron4dev opened this issue Dec 3, 2019 · 6 comments
Labels
cloudformation package-deploy customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. has-pr This issue has a PR associated with it. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue

Comments

@miron4dev
Copy link

miron4dev commented Dec 3, 2019

I would like to deploy a SAM application to localstack.
I execute the command

aws cloudformation package \
    --output-template-file packaged.yml \
    --endpoint-url http://localhost:4581 \ 
    --profile localstack \
    --s3-bucket my-bucket \
    --template-file template.yaml

but get

Unable to upload artifact XXX referenced by CodeUri parameter of XXX resource.
An error occurred (InvalidAccessKeyId) when calling the PutObject operation: The AWS Access Key Id you provided does not exist in our records.

because it requests real S3 instead of using the local one.

I need an additional option like --s3-endpoint-url to solve this issue.

There is #3309 PR, but it was not checked for a year.
See also localstack/localstack#1783

@joguSD
Copy link
Contributor

joguSD commented Dec 18, 2019

Marking this as a feature request. If you'd like to see this feature please thumbs up the opening comment so this request can be appropriately prioritized.

@whummer
Copy link

whummer commented May 25, 2020

Thanks @joguSD , looks like we currently already have a significant number of thumbs ups (41 at this point). What is the threshold for getting this issue prioritized in one of the upcoming releases?

In general, this is currently blocking a fairly large user base of LocalStack users from upgrading their AWS CLI to the latest version. Would be great to see this getting picked up.

There's already an open pull request for this issue - perhaps we can take this as a starting point? #3309

Thanks a lot!

@whummer
Copy link

whummer commented Jul 21, 2020

FYI - we integrated this change directly into the awslocal command line for now, as a temporary workaround until this PR is merged: #3309 Thanks

@kdaily kdaily added the customization Issues related to CLI customizations (located in /awscli/customizations) label Nov 12, 2020
@kdaily kdaily added the has-pr This issue has a PR associated with it. label Aug 5, 2021
@kdaily
Copy link
Member

kdaily commented Apr 22, 2022

Hi everyone,

Thank you for your patience, and I apologize that it's taken so long to get this reviewed. We're making some changes to our community contribution process to provide more transparency and make community contributions successful.

The PR linked to this issue should be reviewed within the next couple weeks as we work through all open pull requests to see where they fall in our newly proposed contribution process.

You can read more about the changes to the contribution process here.

@kdaily kdaily added the needs-review This issue or pull request needs review from a core team member. label Apr 22, 2022
@tim-finnigan tim-finnigan added the p2 This is a standard priority issue label Nov 9, 2022
@tim-finnigan
Copy link
Contributor

Hi all - thanks again for your patience. Per this recent announcement you can now specify the endpoint to use for all service requests through the shared configuration file and environment variables, as well as specify the endpoint URL for individual AWS services.

To start using this feature, install the AWS CLI >=1.29.0 or >=2.13.0.

To read more about this feature, see the documentation page "Service-specific Endpoints" in the AWS SDKs and Tools Reference Guide:

https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloudformation package-deploy customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. has-pr This issue has a PR associated with it. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

5 participants