Test failures on Python 3.12

[limburgher]

Describe the bug

Build on Fedora rawhide fails due to test failures. Tests work on f38 with Python 3.11.

Expected Behavior

Tests pass

Current Behavior

build.log

Reproduction Steps

Build botocore and boto3, install, build awscli.

Possible Solution

No response

Additional Information/Context

No response

CLI version used

1.29.2

Environment details (OS name and version, etc.)

Fedora 39, Python 3.12

[RyanFitzSimmonsAK]

Hi @limburgher, thanks for reaching out. We currently only support up to Python 3.11, but 3.12 pre-release (see: boto/botocore#2967) testing has begun, so I will leave this open for tracking and update you here if anything changes.

[limburgher]

Thank you. We already have 3.12 in Fedora rawhide, so if there's even an rough patch you'd like help testing, let me know.

[hroncok]

E               AttributeError: 'called_with' is not a valid assertion. Use a spec for the mock if 'called_with' is meant to be an attribute.

That's here:

aws-cli/tests/functional/eks/test_kubeconfig.py

Lines 122 to 123 in f169403

	self._validator.validate_config.called_with(Kubeconfig(simple_path,
	content))

aws-cli/tests/functional/eks/test_kubeconfig.py

Lines 131 to 132 in f169403

	self._validator.validate_config.called_with(
	Kubeconfig(no_exist_path, _get_new_kubeconfig_content()))

aws-cli/tests/functional/eks/test_kubeconfig.py

Lines 139 to 141 in f169403

	self._validator.validate_config.called_with(
	Kubeconfig(empty_path,
	_get_new_kubeconfig_content()))

The method call does nothing in Python 3.11. If it's meant to do nothing, delete it. If it's meant to assert the call happened, change the method name to assert_called_with.

[nateprewitt]

This was resolved prior to the release of 3.12 but we missed closing this issue. The CLI test suite should be running properly on 3.12 for all releases since October 4th.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.