Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures on Python 3.12 #8031

Closed
limburgher opened this issue Jul 11, 2023 · 5 comments
Closed

Test failures on Python 3.12 #8031

limburgher opened this issue Jul 11, 2023 · 5 comments
Assignees
Labels
bug This issue is a bug. p3 This is a minor priority issue

Comments

@limburgher
Copy link

Describe the bug

Build on Fedora rawhide fails due to test failures. Tests work on f38 with Python 3.11.

Expected Behavior

Tests pass

Current Behavior

build.log

Reproduction Steps

Build botocore and boto3, install, build awscli.

Possible Solution

No response

Additional Information/Context

No response

CLI version used

1.29.2

Environment details (OS name and version, etc.)

Fedora 39, Python 3.12

@limburgher limburgher added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 11, 2023
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Jul 11, 2023
@RyanFitzSimmonsAK RyanFitzSimmonsAK added investigating This issue is being investigated and/or work is in progress to resolve the issue. p3 This is a minor priority issue and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 11, 2023
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @limburgher, thanks for reaching out. We currently only support up to Python 3.11, but 3.12 pre-release (see: boto/botocore#2967) testing has begun, so I will leave this open for tracking and update you here if anything changes.

@RyanFitzSimmonsAK RyanFitzSimmonsAK added bug This issue is a bug. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 11, 2023
@limburgher
Copy link
Author

Thank you. We already have 3.12 in Fedora rawhide, so if there's even an rough patch you'd like help testing, let me know.

@hroncok
Copy link

hroncok commented Jul 12, 2023

E               AttributeError: 'called_with' is not a valid assertion. Use a spec for the mock if 'called_with' is meant to be an attribute.

That's here:

self._validator.validate_config.called_with(Kubeconfig(simple_path,
content))

self._validator.validate_config.called_with(
Kubeconfig(no_exist_path, _get_new_kubeconfig_content()))

self._validator.validate_config.called_with(
Kubeconfig(empty_path,
_get_new_kubeconfig_content()))

The method call does nothing in Python 3.11. If it's meant to do nothing, delete it. If it's meant to assert the call happened, change the method name to assert_called_with.

@nateprewitt
Copy link
Member

This was resolved prior to the release of 3.12 but we missed closing this issue. The CLI test suite should be running properly on 3.12 for all releases since October 4th.

Copy link

github-actions bot commented Nov 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

4 participants