Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] [autoscaling] [start-instance-refresh] Support parameter in Preferences: "MaxHealthyPercentage" #8338

Closed
2 tasks
p24-max opened this issue Nov 17, 2023 · 2 comments
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@p24-max
Copy link

p24-max commented Nov 17, 2023

Describe the feature

Within the AWS console (EC2-Autoscaling Instance-Refresh), it is possible to specify a MaxHealthyPercentage during an instance refresh.

This is how the "preferences" look like in CloudTrail when performing an instance refresh from AWS management console:

"requestParameters": {
    "autoScalingGroupName": "Web-2023102407231962040000000c",
    "preferences": {
        "standbyInstances": "Ignore",
        "minHealthyPercentage": 100,
        "scaleInProtectedInstances": "Ignore",
        "autoRollback": false,
        "skipMatching": false,
        "maxHealthyPercentage": 110
    }
},

With AWS CLI v2, it is not possible to specify the MaxHealthyPercentage, so please add support for it.

Use Case

Use the new Instance replacement method

image

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CLI version used

aws-cli/2.13.36 Python/3.11.6 Darwin/23.1.0 source/arm64 prompt/off

Environment details (OS name and version, etc.)

MacOS m-chip

@p24-max p24-max added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 17, 2023
@tim-finnigan tim-finnigan self-assigned this Nov 21, 2023
@tim-finnigan
Copy link
Contributor

Hi @p24-max thanks for reaching out. It looks like MaxHealthyPerecentage was just added in version 2.13.37 per the CHANGELOG (and in 1.30.1 for v1), and is in the documentation:

MaxHealthyPercentage -> (integer)

Specifies the maximum percentage of the group that can be in service and healthy, or pending, to support your workload when replacing instances. The value is expressed as a percentage of the desired capacity of the Auto Scaling group. Value range is 100 to 200.

If you specify MaxHealthyPercentage , you must also specify MinHealthyPercentage , and the difference between them cannot be greater than 100. A larger range increases the number of instances that can be replaced at the same time.

If you do not specify this property, the default is 100 percent, or the percentage set in the instance maintenance policy for the Auto Scaling group, if defined.

The updated service API models are in 1.32.1+ of Botocore, which will update when you update your version of the CLI.

@tim-finnigan tim-finnigan removed the needs-triage This issue or PR still needs to be triaged. label Nov 21, 2023
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants