Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing in relative path installs broken symlinks #8799

Closed
timhughes opened this issue Jul 12, 2024 · 2 comments
Closed

Installing in relative path installs broken symlinks #8799

timhughes opened this issue Jul 12, 2024 · 2 comments
Assignees
Labels
bug This issue is a bug. duplicate This issue is a duplicate. installation

Comments

@timhughes
Copy link

Describe the bug

When installing in relative paths , the links created point to the wrong spot

Expected Behavior

Symlinks should point to the correct location

❯ ll .local/bin/aws*
lrwxrwxrwx 1 ttimhu users 52 2024-07-12 15:09 .local/bin/aws -> /home/ttimhu/.local/share/aws-cli/v2/current/bin/aws
lrwxrwxrwx 1 ttimhu users 62 2024-07-12 15:09 .local/bin/aws_completer -> /home/ttimhu/.local/share/aws-cli/v2/current/bin/aws_completer

Current Behavior

❯ ll .local/bin/aws*
total 31456
lrwxrwxrwx 1 ttimhu users       39 2024-07-12 15:04 aws -> .local/share/aws-cli/v2/current/bin/aws
lrwxrwxrwx 1 ttimhu users       49 2024-07-12 15:04 aws_completer -> .local/share/aws-cli/v2/current/bin/aws_completer

Reproduction Steps

cd $HOME
curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
./aws/install --install-dir .local/share/aws-cli --bin-dir .local/bin

Possible Solution

Adding a tilde at the front of all paths fixes it but shouldn't be required

./aws/install --install-dir ~/.local/share/aws-cli --bin-dir ~/.local/bin --update

Additional Information/Context

No response

CLI version used

aws-cli/2.17.12

Environment details (OS name and version, etc.)

Linux

@timhughes timhughes added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2024
@tim-finnigan tim-finnigan self-assigned this Jul 12, 2024
@tim-finnigan tim-finnigan added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Jul 12, 2024
@tim-finnigan
Copy link
Contributor

Thanks for reaching out. This issue is currently being tracked in #6852. I changed that issue title to this one as it more clearly highlights the problem. As mentioned in this comment, the fix would be to "automatically expand the paths at runtime for the install script so they're properly stored in the aws bin file.". I will close this in order to continue tracking there, please refer to that issue for updates going forward.

@tim-finnigan tim-finnigan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
@tim-finnigan tim-finnigan added duplicate This issue is a duplicate. installation and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. duplicate This issue is a duplicate. installation
Projects
None yet
Development

No branches or pull requests

2 participants