Replace outdated bucket placeholders with updated example buckets. #8919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Script was |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8919 +/- ##
==========================================
- Coverage 0.08% 0.08% -0.01%
==========================================
Files 210 210
Lines 16902 16911 +9
==========================================
Hits 14 14
- Misses 16888 16897 +9 ☔ View full report in Codecov by Sentry. |
|
Commenting for posterity. Spoke to David offline about fixing some of the regex replacements. |
|
Looks like a couple stragglers found with |
Update search to be case insensitive Remove aws... and my-s3-... prefixes Remove dashes in -1 -2
DavidSouther
force-pushed
the
draft/bucket_rename
branch
from
7d09e24
to
7e798a8
Compare
kdaily
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
There is an internal effort to rename placeholder BUCKET_NAMES with reserved bucket_names across AWS docs.
Description of changes:
Performed an update across example files using
sed -I '' -f .../buckets.sed **/*.rstfrom the examples folder.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.