Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Ported boto/botocore#3232 from botocore, which gracefully handles invalid expires timestamps from S3.
Testing:
In addition to passing existing and newly added tests for this functionality, I did manual testing to verify the new field is included in the response body of the GetObject operation. Below is an example manual test using the command
aws s3api get-object --bucket bucketname --key filename outfile
:This can be compared to the output of the exact same command using the current latest release:
Additionally, I updated the documention to reflect this in a way that matches botocore's documentation as of writing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.