Skip to content

Commit 8e5884b

Browse files
committed
Fix(sdk): Fix completion logic hole for map/parallel
Changes: Fixes completion logic hole where all items are completed but there is > 1 failure which prevents termination and hangs the execution.
1 parent a4cad39 commit 8e5884b

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

src/aws_durable_execution_sdk_python/concurrency.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -427,15 +427,7 @@ def is_complete(self) -> bool:
427427

428428
# All tasks completed
429429
if completed_count == self.total_tasks:
430-
# Complete if no failure tolerance OR no failures OR min successful reached
431-
return (
432-
(
433-
self.tolerated_failure_count is None
434-
and self.tolerated_failure_percentage is None
435-
)
436-
or self.failure_count == 0
437-
or self.success_count >= self.min_successful
438-
)
430+
return True
439431

440432
# when we breach min successful, we've completed
441433
return self.success_count >= self.min_successful

0 commit comments

Comments
 (0)