Skip to content

Skip null check in doMarshal JSON serializer - #6807

Merged
RanVaknin merged 6 commits into
masterfrom
rvaknin/json-serializer-null-skip
Mar 30, 2026
Merged

Skip null check in doMarshal JSON serializer#6807
RanVaknin merged 6 commits into
masterfrom
rvaknin/json-serializer-null-skip

Add comment for better readability

04525b5
Select commit
Loading
Failed to load commit list.
Refresh
SonarQubeCloud / SonarCloud Code Analysis failed Mar 25, 2026 in 15m 52s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 263 in services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart/UploadWithUnknownContentLengthHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0nbr-bassvNkiMkKV3&open=AZ0nbr-bassvNkiMkKV3&pullRequest=6807

Check warning on line 132 in core/protocols/aws-json-protocol/src/test/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0YIZPRS-WNYeg2GOwk&open=AZ0YIZPRS-WNYeg2GOwk&pullRequest=6807

Check warning on line 222 in services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart/UploadWithUnknownContentLengthHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove useless curly braces around statement 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0nbr-bassvNkiMkKV1&open=AZ0nbr-bassvNkiMkKV1&pullRequest=6807

Check warning on line 272 in services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/multipart/KnownContentLengthAsyncRequestBodySubscriberTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Immediately return this expression instead of assigning it to the temporary variable "existingParts". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0nbr_SassvNkiMkKV6&open=AZ0nbr_SassvNkiMkKV6&pullRequest=6807

Check warning on line 96 in core/protocols/aws-json-protocol/src/test/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0YIZPRS-WNYeg2GOwj&open=AZ0YIZPRS-WNYeg2GOwj&pullRequest=6807

Check warning on line 289 in services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart/UploadWithUnknownContentLengthHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary boolean literal. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0nbr-bassvNkiMkKV4&open=AZ0nbr-bassvNkiMkKV4&pullRequest=6807

Check warning on line 63 in services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtAsyncHttpClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'software.amazon.awssdk.crt.s3.S3MetaRequestResponseHandler'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0YIY7TS-WNYeg2GOwh&open=AZ0YIY7TS-WNYeg2GOwh&pullRequest=6807

Check warning on line 159 in services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart/UploadWithUnknownContentLengthHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this instance-reference to a static reference. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0nbr-bassvNkiMkKV0&open=AZ0nbr-bassvNkiMkKV0&pullRequest=6807

Check warning on line 126 in services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart/UploadWithUnknownContentLengthHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "maximumChunkSizeInByte" private field. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0nbr-bassvNkiMkKV5&open=AZ0nbr-bassvNkiMkKV5&pullRequest=6807

Check warning on line 82 in core/protocols/aws-json-protocol/src/test/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0YIZPRS-WNYeg2GOwi&open=AZ0YIZPRS-WNYeg2GOwi&pullRequest=6807

Check warning on line 471 in services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/DefaultS3CrtAsyncClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0YIY2dS-WNYeg2GOwg&open=AZ0YIY2dS-WNYeg2GOwg&pullRequest=6807

Check warning on line 204 in services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/multipart/KnownContentLengthAsyncRequestBodySubscriberTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "subscriber" which hides the field declared at line 66. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0nbr_SassvNkiMkKV7&open=AZ0nbr_SassvNkiMkKV7&pullRequest=6807

Check warning on line 229 in services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart/UploadWithUnknownContentLengthHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "contentLength" which hides the field declared at line 119. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0nbr-bassvNkiMkKV2&open=AZ0nbr-bassvNkiMkKV2&pullRequest=6807

Check warning on line 245 in services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/multipart/UploadWithUnknownContentLengthHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call "Optional#isPresent()" before accessing the value. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0nbr-bassvNkiMkKVz&open=AZ0nbr-bassvNkiMkKVz&pullRequest=6807
View more details on SonarQubeCloud