Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 Development: DefineConstants requires an overhaul #3326

Open
2 tasks
danielmarbach opened this issue May 30, 2024 · 1 comment
Open
2 tasks

V4 Development: DefineConstants requires an overhaul #3326

danielmarbach opened this issue May 30, 2024 · 1 comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue queued v4

Comments

@danielmarbach
Copy link
Contributor

Describe the feature

The constants defined in the project have grown over the years and are a bit messy. There is still BCL constants defined and some of the constants look like they are the standard constants but are actually not. It would be good to do a general sweep over the v4 development branch and get rid of unnecessary constants, BCL definitions and rely as much as possible on the constants already defined by the SDK.

Also some of the defined constants are unnecessarily specific. For example it would be enough with the current target frameworks to use NETSTANDARD, NETCOREAPP and NET and once NETCOREAPP is dropped just NETSTANDARD and NET.

Use Case

Less cognitive overhead for everyone involved

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

All

Targeted .NET Platform

All

Operating System and version

All

@danielmarbach danielmarbach added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 30, 2024
@dscpinheiro dscpinheiro added needs-review v4 and removed needs-triage This issue or PR still needs to be triaged. labels May 30, 2024
@normj
Copy link
Member

normj commented May 30, 2024

Agreed they do need to be clean up. These constants started getting used in the SDK during the pre 1.0 of .NET Core and we have never gone back to clean them up to use the standard constants. I'll try and take a look how hard it would be to switch to the standard constants.

@ashishdhingra ashishdhingra added the p2 This is a standard priority issue label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue queued v4
Projects
None yet
Development

No branches or pull requests

4 participants