Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSXRayEntityFramework6 is not available for .Net Core #286

Open
sykesbPragmatics opened this issue Feb 24, 2023 · 1 comment
Open

AWSXRayEntityFramework6 is not available for .Net Core #286

sykesbPragmatics opened this issue Feb 24, 2023 · 1 comment

Comments

@sykesbPragmatics
Copy link

I have a .Net Core 6.0 Application that references Entity Framework 6 (Version 6.4.4) and I'm trying to add tracing for EF6

Documentation:
https://github.com/aws/aws-xray-sdk-dotnet/tree/master#net-1

Or you can call it in the DbConfiguration class if there is one in your application to configure execution policy.

using Amazon.XRay.Recorder.Handlers.EntityFramework;

public class YourDbConfiguration : DbConfiguration
{
    public YourDbConfiguration()
    {
        AWSXRayEntityFramework6.AddXRayInterceptor();
    }
}

The Project file for AWSXRayRecorder.Handlers.EntityFramework.csproj explicitly removes this class file for .Net 2.0 Standard and .Net Core 6.0.

Why? EF6 is compatible with .Net Core 6.0

Additionally if there is a blocker, the documentation should be updated to indicate that it only works with .Net Framework

@srprash
Copy link
Collaborator

srprash commented Mar 13, 2023

Hi @sykesbPragmatics
Apologies for the late response. The decision to not support EF6 tracing with any of the .Net Core platform was taken because Microsoft recommends using EFCore for the new .NetCore applications, and that is usually a common practice.

We can look into adding the EF6 tracing support for .NetCore but I can't provide the timeline for it. In case, we don't add the support, we will update the documentation as you suggested.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants